Skip to content

Commit 87848e8

Browse files
authored
Merge pull request #15 from jski/bugfix/remove-security-scan-step
Bugfix/remove security scan step
2 parents f09abf7 + 1c269d1 commit 87848e8

2 files changed

Lines changed: 6 additions & 36 deletions

File tree

.github/workflows/build.yml

Lines changed: 2 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -183,11 +183,11 @@ jobs:
183183
promote:
184184
name: Promote to Production
185185
runs-on: ubuntu-latest
186-
needs: [build, test, security-scan]
186+
needs: [build, test]
187187
# Promote on:
188188
# 1. Normal merge to main (not force push)
189189
# 2. Manual workflow dispatch with promote flag enabled
190-
# CRITICAL: Only runs if build, test, AND security-scan all succeed
190+
# CRITICAL: Only runs if build AND test all succeed
191191
if: |
192192
(github.event_name == 'push' && github.ref == 'refs/heads/main' && !github.event.forced) ||
193193
(github.event_name == 'workflow_dispatch' && inputs.promote == true)
@@ -241,36 +241,6 @@ jobs:
241241
242242
echo "✅ Successfully promoted latest tag"
243243
244-
security-scan:
245-
name: Security Scan
246-
runs-on: ubuntu-latest
247-
needs: build
248-
permissions:
249-
contents: read
250-
security-events: write
251-
steps:
252-
- name: Run Trivy vulnerability scanner
253-
uses: aquasecurity/trivy-action@master
254-
with:
255-
image-ref: ghcr.io/${{ github.repository_owner }}/python-container-builder:3.14-${{ github.sha }}
256-
format: 'sarif'
257-
output: 'trivy-results.sarif'
258-
severity: 'CRITICAL,HIGH'
259-
260-
- name: Upload Trivy results to GitHub Security
261-
uses: github/codeql-action/upload-sarif@v4
262-
if: always()
263-
with:
264-
sarif_file: 'trivy-results.sarif'
265-
266-
- name: Print Trivy results summary
267-
uses: aquasecurity/trivy-action@master
268-
if: always()
269-
with:
270-
image-ref: ghcr.io/${{ github.repository_owner }}/python-container-builder:3.14-${{ github.sha }}
271-
format: 'table'
272-
severity: 'CRITICAL,HIGH'
273-
274244
test:
275245
name: Test Images
276246
runs-on: ubuntu-latest

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,11 +60,11 @@ This approach gives you the reliability of official Python builds while maintain
6060

6161
### Security
6262

63-
This project includes automated security measures:
64-
- 🔒 **Nightly Vulnerability Scanning**: All images scanned with [Trivy](https://github.com/aquasecurity/trivy) for CRITICAL and HIGH severity vulnerabilities
65-
- 🔄 **Automated Dependency Updates**: [Dependabot](https://github.com/dependabot) monitors base images and GitHub Actions for security updates
66-
- 📊 **Transparent Results**: Scan results available in the [Security tab](https://github.com/jski/python-container-builder/security/code-scanning)
63+
This project prioritizes security through:
6764
- 🏗️ **Official Base Images**: Built from official Python and Debian Docker images, ensuring timely security patches
65+
- 🔄 **Automated Dependency Updates**: [Dependabot](https://github.com/dependabot) monitors base images and GitHub Actions for security updates
66+
- 🔒 **Distroless Runtime**: The recommended pattern copies only the Python virtualenv to a distroless runtime, minimizing attack surface
67+
- 📦 **Isolated Dependencies**: Virtual environment isolation ensures clean dependency management
6868

6969
## Goals
7070
This project seeks to:

0 commit comments

Comments
 (0)