bug in rmlinesmovingwinc.m

[awakenting]

Hello,
I recently found a bug in another EEG toolbox where the author told me that it propagated from the Chronux toolbox so I wanted to report it here as well. The bug is described in this issue.

[Alireza-Kazemi]

I was working with this package recently and I found this bug. I confirm that it is a bug and its impact is reducing the effect of the filter. So practically the desired frequencies are not going to be filtered out effectively. The fix is as you suggested to store the current datafitwin to datafitwin0 after the smoothing in the rmlinesmovingwinc function

for n=1:nw
   indx=winstart(n):winstart(n)+Nwin-1;
   datawin=data(indx,:);
   [datafitwin,as,fs]=fitlinesc(datawin,params,p,'n',f0);
   Amps{n}=as;
   freqs{n}=fs;
   % datafitwin0=datafitwin; %Should be moved after the smoothing
   if n>1
       datafitwin(1:Noverlap,:)=smooth.*datafitwin(1:Noverlap,:)+(1-smooth).*datafitwin0(Nwin-Noverlap+1:Nwin,:);
   end
   datafitwin0 = datafitwin; %Store the current windowed data for next loop smoothing
   datafit(indx,:)=datafitwin;
end