Theme problems

[jrgant]

• Point shapes not working for theme_pearl()
• Fonts are not fed to theme_ functions via qd_themes()

In general, theming should be much more flexible.

[jrgant]

Now that I look over the theme functionality, theming is a bit of a mess. Doesn't work intuitively.

• dag |> qd_themes_circles() should update the theme for a DAG but doesn't appear to do so reliably.
• Conditioned nodes are only recorded as such via changing their shape to "rectangle" in the node data.frame. These settings should be saved as graph attributes, now that we have the quickdag class. Same for exposures and outcomes.
  • We can introduce coloring schemes based on these settings
  • Provide more flexibility for node shapes
  • Allow the user to simply give the graph object to qd_adjustment_sets(), which will parse the relevant exposure, outcome, and other information.

Consider reworking the whole theming system.

Another thing we may want is to update graph attributes so that the entire graph update history (already logged by DiagrammeR in graph$graph_log, graph$graph_info, etc.) is preserved. Most internal updates are done via DiagrammeR functions, so this should already be largely implemented. Keep an eye out for places where we deviate.

[jrgant]

Theming improvements in progress. Was able to salvage most of the backbone.