diff --git a/manifests/config/webui.pp b/manifests/config/webui.pp index 75a78d7b..cd345d39 100644 --- a/manifests/config/webui.pp +++ b/manifests/config/webui.pp @@ -48,7 +48,7 @@ path => '/etc/httpd/conf.d/ipa.conf', line => " ", notify => Service['httpd'], - after => '', + after => '^', } file_line{'disable_kerberos_via_if_2': @@ -59,4 +59,4 @@ after => 'ErrorDocument\ 401\ /ipa/errors/unauthorized.html', } } -} \ No newline at end of file +} diff --git a/manifests/validate_params.pp b/manifests/validate_params.pp index 543192e3..19e0d527 100644 --- a/manifests/validate_params.pp +++ b/manifests/validate_params.pp @@ -9,10 +9,7 @@ } if $easy_ipa::ip_address != '' { - # TODO: validate_legacy - if !is_ipv4_address($easy_ipa::ip_address) { - fail('The parameter ip_address must pass validation as an IPv4 address.') - } + validate_legacy('String', 'validate_ip_address', $easy_ipa::ip_address) } if $easy_ipa::manage_host_entry { @@ -25,15 +22,8 @@ fail('Parameter "idstart" must be an integer greater than 10000.') } - # TODO: validate_legacy - if ! is_domain_name($easy_ipa::domain) { - fail('The parameter \'domain\' must pass validation as a domain name.') - } - - # TODO: validate_legacy - if ! is_domain_name($easy_ipa::final_realm) { - fail('The parameter \'realm\' must pass validation as a domain name.') - } + validate_legacy('String', 'validate_domain_name', $easy_ipa::domain) + validate_legacy('String', 'validate_domain_name', $easy_ipa::final_realm) if $easy_ipa::ipa_role == 'master' { if length($easy_ipa::admin_password) < 8 { @@ -53,12 +43,12 @@ # TODO: validate_legacy if $easy_ipa::ipa_master_fqdn == ''{ fail("When creating a ${easy_ipa::ipa_role} the parameter named ipa_master_fqdn cannot be empty.") - } elsif !is_domain_name($easy_ipa::ipa_master_fqdn) { - fail('The parameter \'ipa_master_fqdn\' must pass validation as a domain name.') } + validate_legacy('String', 'validate_domain_name', $easy_ipa::ipa_master_fqdn) + if $easy_ipa::final_domain_join_password == '' { fail("When creating a ${easy_ipa::ipa_role} the parameter named domain_join_password cannot be empty.") } } -} \ No newline at end of file +}