From 1695e2fec087d602d60b1680256b164414e4c0d6 Mon Sep 17 00:00:00 2001 From: Jonathan Leitschuh Date: Tue, 9 Aug 2022 03:32:05 +0000 Subject: [PATCH] vuln-fix: Temporary Directory Hijacking or Information Disclosure This fixes either Temporary Directory Hijacking, or Temporary Directory Local Information Disclosure. Weakness: CWE-379: Creation of Temporary File in Directory with Insecure Permissions Severity: High CVSSS: 7.3 Detection: CodeQL & OpenRewrite (https://public.moderne.io/recipes/org.openrewrite.java.security.UseFilesCreateTempDirectory) Reported-by: Jonathan Leitschuh Signed-off-by: Jonathan Leitschuh Bug-tracker: https://github.com/JLLeitschuh/security-research/issues/10 Co-authored-by: Moderne --- jpos/src/test/java/org/jpos/util/DirPollOperationTest.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/jpos/src/test/java/org/jpos/util/DirPollOperationTest.java b/jpos/src/test/java/org/jpos/util/DirPollOperationTest.java index d5106f74d1..26586f39ea 100644 --- a/jpos/src/test/java/org/jpos/util/DirPollOperationTest.java +++ b/jpos/src/test/java/org/jpos/util/DirPollOperationTest.java @@ -24,6 +24,7 @@ import java.io.File; import java.io.FileOutputStream; import java.io.IOException; +import java.nio.file.Files; import org.junit.jupiter.api.AfterEach; import org.junit.jupiter.api.BeforeEach; @@ -62,9 +63,7 @@ public void process(File name) { } private String createTempDir() throws IOException { - File temp = File.createTempFile("dir_poll", "tmp"); - temp.delete(); // delete the file, we want a dir - temp.mkdirs(); + File temp = Files.createTempDirectory("dir_poll" + "tmp").toFile(); return temp.getAbsolutePath(); }