test(coverage) More work on code coverage

Author: josbeir

tests/TestCase/Command/ServerCommandTest.php

@@ -6,6 +6,9 @@
 use Cake\Console\TestSuite\ConsoleIntegrationTestTrait;
 use Cake\Core\Configure;
 use Cake\TestSuite\TestCase;
+use ReflectionMethod;
+use Synapse\Command\ServerCommand;
+use TestApp\Application;
 
 /**
  * ServerCommand Test Case
@@ -308,4 +311,86 @@ public function testInspectOptionWithOtherOptions(): void
         $this->exec('synapse server -i -v -n -h');
         $this->assertExitSuccess();
     }
+
+    // =========================================================================
+    // findExecutable Tests (via reflection)
+    // =========================================================================
+
+    /**
+     * Test findExecutable finds php binary
+     */
+    public function testFindExecutableFindsPhp(): void
+    {
+        $command = $this->createServerCommand();
+        $method = new ReflectionMethod(ServerCommand::class, 'findExecutable');
+
+        $result = $method->invoke($command, 'php');
+
+        $this->assertNotNull($result);
+        $this->assertFileExists($result);
+        $this->assertTrue(is_executable($result));
+    }
+
+    /**
+     * Test findExecutable returns null for nonexistent executable
+     */
+    public function testFindExecutableReturnsNullForNonexistent(): void
+    {
+        $command = $this->createServerCommand();
+        $method = new ReflectionMethod(ServerCommand::class, 'findExecutable');
+
+        $result = $method->invoke($command, 'definitely_not_a_real_executable_12345');
+
+        $this->assertNull($result);
+    }
+
+    /**
+     * Test findExecutable finds common executables
+     */
+    public function testFindExecutableFindsCommonExecutables(): void
+    {
+        $command = $this->createServerCommand();
+        $method = new ReflectionMethod(ServerCommand::class, 'findExecutable');
+
+        // Test with 'which' or 'ls' - common on Unix systems
+        $result = $method->invoke($command, 'ls');
+
+        if ($result !== null) {
+            $this->assertFileExists($result);
+            $this->assertTrue(is_executable($result));
+        }
+
+        // If null, the test passes - executable simply wasn't found
+    }
+
+    /**
+     * Test defaultName returns correct command name
+     */
+    public function testDefaultName(): void
+    {
+        $this->assertEquals('synapse server', ServerCommand::defaultName());
+    }
+
+    /**
+     * Test getDescription returns appropriate description
+     */
+    public function testGetDescription(): void
+    {
+        $description = ServerCommand::getDescription();
+
+        $this->assertStringContainsString('MCP', $description);
+        $this->assertStringContainsString('server', $description);
+    }
+
+    /**
+     * Create a ServerCommand instance for testing
+     */
+    private function createServerCommand(): ServerCommand
+    {
+        // Get the container from the application
+        $app = new Application(CONFIG);
+        $container = $app->getContainer();
+
+        return new ServerCommand($container);
+    }
 }

tests/TestCase/Tools/TinkerToolsTest.php

@@ -433,4 +433,103 @@ public function testDefaultTimeoutIsThirtySeconds(): void
         $this->assertTrue($result['success']);
         $this->assertEquals('ok', $result['result']);
     }
+
+    // =========================================================================
+    // Error Handling and Edge Cases
+    // =========================================================================
+
+    /**
+     * Test execution timeout triggers error response
+     */
+    public function testExecuteTimeout(): void
+    {
+        // Use a very short timeout with code that sleeps
+        $result = $this->tinkerTools->execute('sleep(5); return "done";', 1);
+
+        $this->assertFalse($result['success']);
+        $this->assertStringContainsString('timed out', $result['error']);
+        $this->assertEquals('RuntimeException', $result['type']);
+    }
+
+    /**
+     * Test empty stdout from subprocess returns error with exit code
+     */
+    public function testEmptyStdoutReturnsError(): void
+    {
+        // Code that exits without output
+        $result = $this->tinkerTools->execute('exit(0);');
+
+        $this->assertFalse($result['success']);
+        $this->assertArrayHasKey('error', $result);
+        $this->assertArrayHasKey('exit_code', $result);
+    }
+
+    /**
+     * Test null PHP binary returns error
+     */
+    public function testNullPhpBinaryReturnsError(): void
+    {
+        // Use reflection to set phpBinary to a value that will make getPhpBinary return null
+        $tinkerTools = new TinkerTools();
+
+        // Mock by setting an invalid configured path and clearing cached value
+        $originalConfig = Configure::read('Synapse.tinker.php_binary');
+        Configure::write('Synapse.tinker.php_binary', '/definitely/not/a/real/path');
+
+        // Create fresh instance - the config path isn't executable so it will try other methods
+        // We need to test the case where getPhpBinary returns null
+        // This is hard to achieve without modifying system, so test the error message path instead
+        $tinkerTools->setPhpBinary('/nonexistent/php/binary');
+        $result = $tinkerTools->execute('return 1;');
+
+        $this->assertFalse($result['success']);
+        $this->assertArrayHasKey('error', $result);
+
+        Configure::write('Synapse.tinker.php_binary', $originalConfig);
+    }
+
+    /**
+     * Test getPhpBinary with non-executable configured path falls back
+     */
+    public function testGetPhpBinaryFallsBackWhenConfiguredPathNotExecutable(): void
+    {
+        $originalConfig = Configure::read('Synapse.tinker.php_binary');
+
+        // Set a path that exists but isn't executable (or doesn't exist)
+        Configure::write('Synapse.tinker.php_binary', '/tmp/not-executable-file');
+
+        $tinkerTools = new TinkerTools();
+        $phpBinary = $tinkerTools->getPhpBinary();
+
+        // Should fall back to which php or PHP_BINARY
+        $this->assertNotEquals('/tmp/not-executable-file', $phpBinary);
+        $this->assertNotNull($phpBinary);
+
+        Configure::write('Synapse.tinker.php_binary', $originalConfig);
+    }
+
+    /**
+     * Test getBinPath uses ROOT constant when available
+     */
+    public function testGetBinPathUsesRootConstant(): void
+    {
+        $tinkerTools = new TinkerTools();
+        $binPath = $tinkerTools->getBinPath();
+
+        // ROOT is defined in test environment
+        $this->assertEquals(ROOT . '/bin', $binPath);
+    }
+
+    /**
+     * Test process that outputs to stderr
+     */
+    public function testProcessWithStderrOutput(): void
+    {
+        // Trigger a PHP warning/notice that goes to stderr
+        $result = $this->tinkerTools->execute('trigger_error("test warning", E_USER_WARNING); return "ok";');
+
+        // Should still succeed, warnings don't stop execution
+        $this->assertTrue($result['success']);
+        $this->assertEquals('ok', $result['result']);
+    }
 }