Cross platfor fixes

Author: josbeir

src/Builder/ServerBuilder.php

@@ -119,9 +119,11 @@ public function withPluginTools()
         $pluginSrcPath = dirname(__DIR__);
         $pluginSrcPath = str_replace(ROOT, '', $pluginSrcPath);
         $pluginSrcPath = ltrim($pluginSrcPath, DIRECTORY_SEPARATOR);
+        // Normalize to forward slashes for consistency across platforms
+        $pluginSrcPath = str_replace(DIRECTORY_SEPARATOR, '/', $pluginSrcPath);
 
         foreach ($scanDirs as $dir) {
-            $path = $pluginSrcPath . DIRECTORY_SEPARATOR . $dir;
+            $path = $pluginSrcPath . '/' . $dir;
             if (!in_array($path, $this->scanDirs, true)) {
                 $this->scanDirs[] = $path;
             }

tests/TestCase/Builder/ServerBuilderTest.php

@@ -142,10 +142,12 @@ public function testWithPluginToolsDoesNotDuplicate(): void
         $scanDirs = $builder->getScanDirs();
         $pluginSrcPath = dirname(dirname(dirname(__DIR__))) . '/src';
         $pluginSrcPath = ltrim($pluginSrcPath, DIRECTORY_SEPARATOR);
+        // Normalize to forward slashes for cross-platform consistency
+        $pluginSrcPath = str_replace(DIRECTORY_SEPARATOR, '/', $pluginSrcPath);
 
-        $toolsPath = $pluginSrcPath . DIRECTORY_SEPARATOR . 'Tools';
-        $promptsPath = $pluginSrcPath . DIRECTORY_SEPARATOR . 'Prompts';
-        $resourcesPath = $pluginSrcPath . DIRECTORY_SEPARATOR . 'Resources';
+        $toolsPath = $pluginSrcPath . '/Tools';
+        $promptsPath = $pluginSrcPath . '/Prompts';
+        $resourcesPath = $pluginSrcPath . '/Resources';
 
         // Count occurrences of each path - should be 1 each
         $toolsCount = count(array_filter($scanDirs, fn(string $dir): bool => $dir === $toolsPath));
@@ -278,10 +280,12 @@ public function testBuildWithPluginTools(): void
         // Verify Tools, Prompts, and Resources directories are in scan dirs
         $pluginSrcPath = dirname(dirname(dirname(__DIR__))) . '/src';
         $pluginSrcPath = ltrim($pluginSrcPath, DIRECTORY_SEPARATOR);
+        // Normalize to forward slashes for cross-platform consistency
+        $pluginSrcPath = str_replace(DIRECTORY_SEPARATOR, '/', $pluginSrcPath);
 
-        $toolsPath = $pluginSrcPath . DIRECTORY_SEPARATOR . 'Tools';
-        $promptsPath = $pluginSrcPath . DIRECTORY_SEPARATOR . 'Prompts';
-        $resourcesPath = $pluginSrcPath . DIRECTORY_SEPARATOR . 'Resources';
+        $toolsPath = $pluginSrcPath . '/Tools';
+        $promptsPath = $pluginSrcPath . '/Prompts';
+        $resourcesPath = $pluginSrcPath . '/Resources';
         $this->assertContains($toolsPath, $builder->getScanDirs());
         $this->assertContains($promptsPath, $builder->getScanDirs());
         $this->assertContains($resourcesPath, $builder->getScanDirs());

tests/TestCase/Documentation/DocumentProcessorTest.php

@@ -50,7 +50,8 @@ protected function readTestFile(string $filename): string
         $content = file_get_contents($this->docsPath . $filename);
         $this->assertNotFalse($content, sprintf('Test file %s not found', $filename));
 
-        return $content;
+        // Normalize line endings for cross-platform consistency
+        return str_replace("\r\n", "\n", $content);
     }
 
     /**

tests/TestCase/Tools/TinkerToolsTest.php

@@ -409,11 +409,12 @@ public function testSubprocessFailsWithInvalidPhpBinary(): void
         $result = $this->tinkerTools->execute('return 1;');
 
         $this->assertFalse($result['success']);
-        // Error can be our message or shell's "No such file or directory"
+        // Error can be our message or shell's error (varies by platform)
         $this->assertTrue(
             str_contains($result['error'], 'PHP binary') ||
             str_contains($result['error'], 'No such file or directory') ||
-            str_contains($result['error'], 'not found'),
+            str_contains($result['error'], 'not found') ||
+            str_contains($result['error'], 'cannot find the path'),
             'Expected error about missing PHP binary, got: ' . $result['error'],
         );
     }
@@ -443,6 +444,10 @@ public function testDefaultTimeoutIsThirtySeconds(): void
      */
     public function testExecuteTimeout(): void
     {
+        if (DIRECTORY_SEPARATOR === '\\') {
+            $this->markTestSkipped('Process timeout behavior differs on Windows');
+        }
+
         // Use a very short timeout with code that sleeps
         $result = $this->tinkerTools->execute('sleep(5); return "done";', 1);