Skip to content

Review #1

@yuvalbl

Description

@yuvalbl

Sanity check: OK

Code inspection: OK

  • See minor warnings

Project Structure:

  • IDE Files (.idea) should not be included on repo!

Readability (Complexity Magic numbers, function / line length): OK

  • Some long functions (createServer)

Naming (files, functions, variables): OK

Efficiency: OK

  • Why not share cache logic for both cache mechanisms?

Documentation (Readme, inline): Missing

  • Almost no comments at all
  • Readme can be improved

Error handling:

  • When using fetch - attach catch action to it

Unexpected request handling: OK

Cleanup (remove unneeded conde, comments etc.): OK

  • Remove unused parameters, or leave a comment why you’ve left them

General

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions