-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Description
Sanity check: OK
Code inspection: OK
- See minor warnings
Project Structure:
- IDE Files (.idea) should not be included on repo!
Readability (Complexity Magic numbers, function / line length): OK
- Some long functions (createServer)
Naming (files, functions, variables): OK
Efficiency: OK
- Why not share cache logic for both cache mechanisms?
Documentation (Readme, inline): Missing
- Almost no comments at all
- Readme can be improved
Error handling:
- When using
fetch- attachcatchaction to it
Unexpected request handling: OK
- http://localhost:3000/api/h.t will crash the server
Cleanup (remove unneeded conde, comments etc.): OK
- Remove unused parameters, or leave a comment why you’ve left them
General
- Do not chain urls like http://localhost:3000/api/https://api.openweathermap.org/ ...
- Graber - nice work. While dragging, indication should be displayed
- Prefer using
classoveridselector for css styles
Metadata
Metadata
Assignees
Labels
No labels