-
Notifications
You must be signed in to change notification settings - Fork 295
Open
Description
Description
In TargetTrigger.onStart(Scope what, Workout s), the method resets internal state but doesn’t clear the paused flag.
If the same trigger instance was paused or stopped earlier, it remains paused after restart — preventing any trigger actions from firing.
File / Code
File: app/src/main/org/runnerup/workout/TargetTrigger.java
@Override
public void onStart(Scope what, Workout s) {
if (this.scope == what) {
reset();
for (Feedback f : triggerAction) {
f.onStart(s);
}
}
}Steps to Reproduce
- Create a
TargetTriggerand let it run. - Call
onPause()oronStop()(setspaused = true). - Call
onStart(...)again. - Observe that no actions are fired during subsequent ticks.
Expected Behavior
onStart should clear paused to resume normal operation.
Actual Behavior
paused remains true, so no trigger actions occur after restarting.
Impact
Trigger never activates after being paused or stopped, affecting pacing or HR feedback.
Proposed Fix
Add this line at the start of the method:
paused = false;Metadata
Metadata
Assignees
Labels
No labels