Can this plugin handle OR ?

[sadtab]

Can this handle OR ? Like hostname foo OR bar

[johnlettman]

No; however, I would be glad to add this feature.

[johnlettman]

c2ee8e1

[sadtab]

God-tier responsiveness right here, if only my prayers got merged this quickly

[johnlettman]

Hahaha, I aim to be responsive -- even if I don't always achieve that.
I hope it works well for your system! Thank you for the recommendation to improve it.

[sadtab]

@johnlettman I'm affraid the OR is not working properly, I just copied the example in the documentation, tried with a fresh dotbot sub module initialization and it failed :

An error was encountered while executing action ifhostname
Action ifhostname not handled
An error was encountered while executing action ifhostname
Action ifhostname not handled
An error was encountered while executing action ifhostname
Action ifhostname not handled

==> Some tasks were not executed successfully

[johnlettman]

Oh dear, that's not good at all. I suppose the tests I wrote don't shake this out well enough. I will fix that today and test it on a sample configuration with a live machine.

[sadtab]

Happy new year @johnlettman, I spent some time today trying to debug this with an LLM, I added these prints in the handler :

    def handle_ifplatform(self, data: Any) -> bool:
        """Process the provided data under the ifhostname directive."""
        expected = data.get("hostname")
        print("DEBUG hostname:", repr(get_hostname()))
        print("DEBUG expected:", expected)
...

This is what I get for a given hotname list ['A', 'B', 'C']:

DEBUG hostname: 'X'
DEBUG expected: ['A', 'B', 'C']
An error was encountered while executing action ifhostname
Action ifhostname not handled

It seems your logic is getting the right information to parse but is not returning something properly to dorbot, or something like that, it seems something in inconsistent between plugin and dotbot

Let me know if there is anything to do to fix it

[johnlettman]

Happy New Year, friend! Thank you for reminding me of this. I did see the same issue, and I'm not 100% why it happens, but I will take another crack at it tonight and tomorrow.