From 98d2ae77a80f9f2da7a7a00746277215163d367c Mon Sep 17 00:00:00 2001 From: John Carlo Manuel <39042556+johncmanuel@users.noreply.github.com> Date: Thu, 19 Mar 2026 15:11:22 -0700 Subject: [PATCH 1/5] change name --- .github/workflows/desktop-build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/desktop-build.yml b/.github/workflows/desktop-build.yml index 394186e..9955bfa 100644 --- a/.github/workflows/desktop-build.yml +++ b/.github/workflows/desktop-build.yml @@ -37,7 +37,7 @@ jobs: submodules: recursive - name: Build wails - uses: host-uk/build@v4 + uses: dAppCore/build@v4 id: build with: build-name: ${{ env.APP_NAME }} From 8fb74ae2fe615ce1fb4b62d6ab13d778c70e7064 Mon Sep 17 00:00:00 2001 From: John Carlo Manuel <39042556+johncmanuel@users.noreply.github.com> Date: Thu, 19 Mar 2026 15:14:07 -0700 Subject: [PATCH 2/5] try 4.0.0 --- .github/workflows/desktop-build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/desktop-build.yml b/.github/workflows/desktop-build.yml index 9955bfa..f07e07e 100644 --- a/.github/workflows/desktop-build.yml +++ b/.github/workflows/desktop-build.yml @@ -37,7 +37,7 @@ jobs: submodules: recursive - name: Build wails - uses: dAppCore/build@v4 + uses: dAppCore/build@v4.0.0 id: build with: build-name: ${{ env.APP_NAME }} From c7a98438689b314febdfe74d2b7f932a26397a9f Mon Sep 17 00:00:00 2001 From: John Carlo Manuel <39042556+johncmanuel@users.noreply.github.com> Date: Thu, 19 Mar 2026 15:25:28 -0700 Subject: [PATCH 3/5] try to change node version --- .github/workflows/desktop-build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/desktop-build.yml b/.github/workflows/desktop-build.yml index f07e07e..fd3e91c 100644 --- a/.github/workflows/desktop-build.yml +++ b/.github/workflows/desktop-build.yml @@ -46,7 +46,7 @@ jobs: # need to keep node at 22.x rather than latest to avoid build issues with # libwebkit2gtk-4.0-dev (AFAIK, ubuntu 24 drops this specific package). This # version is needed to work with wails - # node-version: "22.x" + node-version: "22.x" # - name: Build wails # uses: dAppServer/wails-build-action@v2.2 From 37c2dc7f3b607d6282f192fca19d2e629ca2e10a Mon Sep 17 00:00:00 2001 From: John Carlo Manuel <39042556+johncmanuel@users.noreply.github.com> Date: Thu, 19 Mar 2026 15:46:40 -0700 Subject: [PATCH 4/5] set up node before wails action --- .github/workflows/desktop-build.yml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/workflows/desktop-build.yml b/.github/workflows/desktop-build.yml index fd3e91c..3308c71 100644 --- a/.github/workflows/desktop-build.yml +++ b/.github/workflows/desktop-build.yml @@ -36,6 +36,11 @@ jobs: with: submodules: recursive + - name: Set up Node.js + uses: actions/setup-node@v4 + with: + node-version: '22.x' + - name: Build wails uses: dAppCore/build@v4.0.0 id: build @@ -46,7 +51,7 @@ jobs: # need to keep node at 22.x rather than latest to avoid build issues with # libwebkit2gtk-4.0-dev (AFAIK, ubuntu 24 drops this specific package). This # version is needed to work with wails - node-version: "22.x" + # node-version: "22.x" # - name: Build wails # uses: dAppServer/wails-build-action@v2.2 From d6d66a8f98e51ca2257276167b2e092e55436b4d Mon Sep 17 00:00:00 2001 From: John Carlo Manuel <39042556+johncmanuel@users.noreply.github.com> Date: Thu, 19 Mar 2026 16:54:10 -0700 Subject: [PATCH 5/5] fix workflow --- .github/workflows/desktop-build.yml | 33 ++++++----------------------- 1 file changed, 7 insertions(+), 26 deletions(-) diff --git a/.github/workflows/desktop-build.yml b/.github/workflows/desktop-build.yml index 3308c71..d4e16f6 100644 --- a/.github/workflows/desktop-build.yml +++ b/.github/workflows/desktop-build.yml @@ -17,7 +17,6 @@ env: jobs: build: strategy: - # Failure in one platform build won't impact the others fail-fast: false matrix: build: @@ -28,7 +27,6 @@ jobs: - platform: "darwin/universal" os: "macos-latest" - # https://github.com/dAppServer/wails-build-action/tree/dev/actions/build/wails2#wails-v2-full-pipeline runs-on: ${{ matrix.build.os }} steps: - name: Checkout @@ -36,33 +34,16 @@ jobs: with: submodules: recursive - - name: Set up Node.js - uses: actions/setup-node@v4 - with: - node-version: '22.x' - + # https://github.com/dAppServer/wails-build-action/tree/dev/actions/build/wails2#wails-v2-full-pipeline - name: Build wails - uses: dAppCore/build@v4.0.0 + uses: dAppCore/build/actions/build/wails2@v4.0.0 id: build with: build-name: ${{ env.APP_NAME }} build-platform: ${{ matrix.build.platform }} - # go-version: "1.23" + package: true + go-version: "1.23" # need to keep node at 22.x rather than latest to avoid build issues with - # libwebkit2gtk-4.0-dev (AFAIK, ubuntu 24 drops this specific package). This - # version is needed to work with wails - # node-version: "22.x" - - # - name: Build wails - # uses: dAppServer/wails-build-action@v2.2 - # id: build - # with: - # build-name: ${{ env.APP_NAME }} - # build-platform: ${{ matrix.build.platform }} - # package: true - # go-version: "1.23" - # # need to keep node at 22.x rather than latest to avoid build issues with - # # libwebkit2gtk-4.0-dev (AFAIK, ubuntu 24 drops this specific package). This - # # version is needed to work with wails - # # See linux installation here: https://wails.io/docs/gettingstarted/installation/ - # node-version: "22.x" + # libwebkit2gtk-4.0-dev (AFAIK, ubuntu 24 drops this specific package) as well + # as get Vite to work properly. This version is needed to work with wails + node-version: "22.x"