sleep(1) blocking

[danield0garu]

I'm using sleep(1) and is blocking. It seems like a deadlock in a lower included module

[jochemstoel]

Sleep is supposed to block.

[danday74]

sleep blocks normally agreed. However, the "beauty" of this module is that it does not block. That's why people use it. However, the code in the catch block, the fallback code, does block. That's why you are getting complaints. I don't think there is a fix for this. The module depends on deasync which implements a C++ hack to prevent blocking. The code in the fallback is standard node sleep code which will always block. Basically, if the deasync code does not work and it hits the fallback it will block.

This module is great for dev where you want a quick hack to sleep without blocking during dev. However, it should not be relied on in production where it may block on some systems. I suggest a README update to this effect is in order to let people know when they can safely use this module and when they cannot.

[jochemstoel]

Really? That is the reason people are using system-sleep? I thought I had invented a new unique feature on the computer.

I invite you edit the readme and do one of those pull requests they keep talking about.