TypeError: unsupported operand type(s) for //: 'slice' and 'int' when slicing search results

[gbmerrall]

Version: python3-discogs-client 2.8
Python Version: 3.x (Reproduced on 3.10 and 3.12)

Attempting to slice a search results object (specifically a PaginatedList or MixedPaginatedList) using standard Python slicing notation (e.g., results[:10]) results in a TypeError. Perhaps a regression or an oversight in how the getitem method handles slice objects versus integer indices when calculating page offsets?

import discogs_client

# Initialize client
client = discogs_client.Client('YourUserAgent/0.1', user_token='YOUR_TOKEN')

# Perform a search
results = client.search('van morrison astral weeks', type='release')

# Attempt to slice the results
first_ten = results[:10]

# Trigger the error by iterating or accessing the slice
for item in first_ten:
  print(item.id)

Result: TypeError: unsupported operand type(s) for //: 'slice' and 'int'

Workaround

from itertools import islice
results = client.search('query', type='release')
limited_results = list(islice(results, 10))

[AnssiAhola]

Hey @gbmerrall

Indeed the BasePaginatedResponse does not support slices. This is because it handles new page loads automatically when trying to access a index larger than the defined "per_page" count (+1).

I think the "correct way" is to use the .page() method on results and slice on that, but depending on your usecase you could define the per_page to be 10 so there would be no need for slicing.

query = client.search('van morrison astral weeks', type='release')
query.per_page = 25  # Default is 50
# The actual search is not performed until we access the results

# Get the first page and slice that. This performs the search.
first_ten = query.page(1)[:10]
for item in first_ten:
    print(item.id)

Hope that helps or clarifies how the client works.

Cheers!
-Anssi