Allowing List for fields in directives

[jbkoh]

When I use my schema, a directive throws Only scalar (or nonnull version of this) are supported.

The related part of the schema:

"""The directive is responsible for authorization check."""
directive @auth(
  """Permissions which are required for field access."""
  permissions: [String!]

  """
  The list of roles that an authorized user should have to get the access.
  """
  roles: [String!]
) on FIELD_DEFINITION

I checked the GraphQL spec and it's allowed: https://spec.graphql.org/June2018/#sec-Type-System.Directives

Are we able to fix it? Happy to contribute if you can give some guidance

[jhnnsrs]

Hey @jbkoh

This looks like it might be a `graphql-core erro when validating the schema, as i don't see where we are raising it? Maybe we need to bump the graphql-core dependency for this? Do you want to give it a try?

Also on a side note. Would you care about the option of saving the directive properties as extra kwargs to the field?
i.e

schema

type X {
   name: String @auth(permissions: ["admin"])
}

documents

fragment X on X {
   name
}

generated

class XFragment(BaseModel):
     name: Optional[str] = Field(default=None, auth = {"permissions": ["admin"]})

[jbkoh]

This is where the error occurred:

turms/turms/plugins/strawberry.py

Line 104 in b9e5c27

), "Only scalar (or nonnull version of this) are supported"

Yes it'd be great to see directives as an argument

[jhnnsrs]

Ah so that is the strawberry schema based generation, which is orthogonal to the documents based generation.

This is definitely fixable and should need only a detection of list types similar to as done in the arguments generation (in the operations plugin)

Do you feel like you could provide a PR ( tests and or implementation?)otherwise I could do it in the next week!

[jhnnsrs]

Could you check if 0.8.3 fixes your issues? :)

[jbkoh]

Now I'm getting a different issue possibly related to postponed type annotation (maybe strawberry limitation)

│ ./.venv/lib/python3.10/site-packages/turms/plugins/strawberry.py:84  │                                                                                          
│ in build_directive_type_annotation                                                               │                                                                                          
│                                                                                                  │                                                                                          
│     81 │   │   │   │   ctx=ast.Load(),                                                           │                                                                                          
│     82 │   │   │   )                                                                             │
│     83 │   │                                                                                     │
│ ❱   84 │   │   return registry.reference_enum(value.name)                                        │
│     85 │   if isinstance(value, GraphQLNonNull):                                                 │
│     86 │   │   return build_directive_type_annotation(value.of_type, registry, is_optional=Fals  │
│     87 │   if isinstance(value, GraphQLList):                                                    │
╰──────────────────────────────────────────────────────────────────────────────────────────────────╯
TypeError: ClassRegistry.reference_enum() missing 1 required positional argument: 'parent'

I have a directive using an enum defined below the directive.

[jhnnsrs]

Not a strawberry limitation, rather an oversight from my side. Strawberry does not need model rebuilds.
#86 should fix this now, do you want to check that out? :)