[Q/BUG/FR] FB_INSERT_FILE_INTO_PL vs FB_ADD_FILE_TO_PL_OR_CHDIR

[Apaczer]

QUESTION

What's precise difference between FileBrowserAddFileToPlaylistOrChDir and FileBrowserInsertFileIntoPlaylist in terms of file insertion/addition. Do they behave in the same way when updating Playlist? I thought "insert" would overwrite last track, but it just add new track. I could not find answer in docummention, but while fiddling with both there is small bug (see below).

BUG

Describe the bug
While "adding" and "inserting" music tracks into (SDL 1.2) playlist interchangeably, the Playlist will show for e.g Playlist (3 entries, ... where in fact there're only 2 visible tracks - worse than that you can even navigate to those ghost entries...

To Reproduce
Steps to reproduce the behavior:

1. Go to FileBrowser
2. Add file to playlist
3. Insert file to playlist
4. Add file to playlist
5. Show playlist
6. See ghost entries in playlist view

System:

• Hardware: Any
• OS: Any

Additional context
I wanted to use new input event FileBrowserPlayFileOrChDir, but at the same time there is no new case for simple FileBrowserAddFileToPlaylist, so I decided to use FileBrowserInsertFileIntoPlaylist (see qeustion).

[Apaczer]

well, I will throw here also a request for above scenario:

FEATURE REQUEST

Allow for *.keymap loading without FileBrowserAddFileToPlaylistOrChDir entry, if you have FileBrowserPlayFileOrChDir && FileBrowserInsertFileIntoPlaylist in keymap already. Also add new case event FileBrowserAddFileToPlaylist eventually.

[jhe2]

The FileBrowserAddFileToPlaylistOrChDir action is supposed to either add the selected file to the end of the playlist or in case of a directory change to that directory. As the name suggests, this is only relevant from within the file browser view.

FileBrowserInsertFileIntoPlaylist is supposed to insert the selected file at the current cursor position into the playlist. For instance, if you have selected the third track in the playlist and then insert a file into the playlist, it should be inserted at that position.

[jhe2]

well, I will throw here also a request for above scenario:

FEATURE REQUEST

Allow for *.keymap loading without FileBrowserAddFileToPlaylistOrChDir entry, if you have FileBrowserPlayFileOrChDir && FileBrowserInsertFileIntoPlaylist in keymap already. Also add new case event FileBrowserAddFileToPlaylist eventually.

Since FileBrowserInsertFileIntoPlaylist does not do the same thing as FileBrowserAddFileToPlaylistOrChDir in case of a selected file (see my previous comment), it wouldn't be very useful to allow omitting FileBrowserAddFileToPlaylistOrChDir in that case.

Adding an additional FileBrowserAddFileToPlaylist that can be used instead of/in addition to FileBrowserAddFileToPlaylistOrChDir would make more sense. I simply didn't have a usecase for that, but it shouldn't cause any issues having that option. I'll see what I can do.

As for the bug you described, of course that should not happen. I'll try to reproduce this on my end.

[Apaczer]

Thanks for explanation! I agree, then adding FileBrowserAddFileToPlaylist will be better alternative in conjuction with "FileBrowserPlayFileOrChDir" mapping.

The mentioned "ghost tracks" issue occurs, when adding/inserting tracks at the end of Playlist.

I noticed also that with FileBrowserInsertFileIntoPlaylist key mapping you can choose directory in FileBrowser, so it is in reality (a non-existent) FileBrowserInsertFileIntoPlaylistOrChDir event