-
Notifications
You must be signed in to change notification settings - Fork 172
Description
Culprit:
Line 637 in fcb41b7
| // Probably need not add to pendingScripts, since generally that would have happened already in configuring. |
Source: #300 (comment)
From Daniel:
As 'user', create a Pipeline, write a script that hasn't been used before, disable sandbox, save.
As 'user', build the job, it fails
As 'admin', approve the script.
As 'user' build the job, it works
As 'admin', delete from approvals
As 'user', build the job, it fails
Expected: Script is now pending approval
Actual: It's neither approved nor pending
It's currently blocking the UI enhancement PR.
Current workaround, you need to re-configure the code that is using the script. Just executing it will not trigger the approval request.
Originally reported by
wfollonier, imported from: After removal of approval, usage does not trigger re-approval
- status: Open
- priority: Major
- component(s): script-security-plugin
- resolution: Unresolved
- votes: 0
- watchers: 1
- imported: 2025-12-09
Raw content of original issue
Culprit:
Line 637 in fcb41b7
// Probably need not add to pendingScripts, since generally that would have happened already in configuring. Source: #300 (comment)
From Daniel:
As 'user', create a Pipeline, write a script that hasn't been used before, disable sandbox, save. As 'user', build the job, it fails As 'admin', approve the script. As 'user' build the job, it works As 'admin', delete from approvals As 'user', build the job, it fails Expected: Script is now pending approval Actual: It's neither approved nor pending
It's currently blocking the UI enhancement PR.
Current workaround, you need to re-configure the code that is using the script. Just executing it will not trigger the approval request.