Skip to content

remove yui usage #59

@mawinter69

Description

@mawinter69

Jenkins and plugins versions report

Environment
Jenkins: 2.469
coordinator: 1.5.0

What Operating System are you using (both controller, and any agents involved in the problem)?

not relevant

Reproduction steps

I don't have reproduction steps, but the problem affects disabling the build trigger button

Expected Results

the build trigger button is disabled

Actual Results

button is not disabled

Anything else?

With YUI disabled,
https://github.com/jenkinsci/coordinator-plugin/blob/7cd7b685db90190cffd72ee2e2db6745da9d053f/src/main/webapp/js/cbuild/main.js#L83C4-L83C67
will cause a javascript error visible in the browser console

To fix replace usages of <input type="button" class="yui-button" .../> with <button type="button" class="jenkins-button" ...> and directy get the buildtrigger button with document.getElementById("buildTrigger")
That would require that the plugin depends on a recent Jenkins that has the new jenkins-button css defined.

Are you interested in contributing a fix?

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions