maps are not subscriptable

[keflavich]

I get the error:

]Traceback (most recent call last):
  File "<ipython-input-20-e12c0a20cd7b>", line 1, in <module>
    s = scouse.stage_1(config=config_file, interactive=True) # GUI based
  File "/blue/adamginsburg/adamginsburg/repos/scousepy/scousepy/scouse.py", line 377, in stage_1
    generate_SAAs(self, coverageobject)
  File "/blue/adamginsburg/adamginsburg/repos/scousepy/scousepy/stage_1.py", line 169, in generate_SAAs
    SAA=results[j]
TypeError: 'map' object is not subscriptable

in stage 1. This most likely results from this part:

scousepy/scousepy/stage_1.py

Lines 155 to 169 in 5eb2028

	if scouseobject.njobs > 1:
	# if __name__ == 'scousepy.stage_1':
	# print(__name__)
	results = parallel_map(create_saa, inputlist, numcores=scouseobject.njobs)
	else:
	if scouseobject.verbose:
	results=[create_saa(input) for input in tqdm(inputlist)]
	else:
	results=[create_saa(input) for input in inputlist]
	if scouseobject.verbose:
	progress_bar = print_to_terminal(stage='s1', step='coverageend', length=len(coverage[:,0]),var=w)
	for j in range(len(coverage[:,0])):
	SAA=results[j]

in which parallel_map is used. Most likely, we need to do list(parallel_map...) or restructure the loop on line 168-169 to loop over the entries in the map rather than an index.

[jdhenshaw]

can you dig into this a bit more and tell me what is in results in order to produce this error, results should be a list

[keflavich]

results is not a list because map does not return a list (and neither does parallel_map) - it returns a map object that is not subscriptable. Since you haven't encountered this yourself, it's almost certainly a version issue; I'm using python3.9 with presumably a recent version of parallel_map. I'll submit the PR for this, though, as I'm pretty sure I solved the issue

[jdhenshaw]

in all instances where this occurs in the code (stage 1 and 3) parallel_map (https://github.com/jdhenshaw/scousepy/blob/master/scousepy/parallel_map.py) returns <class 'numpy.ndarray'> - I'm in python3.10 (just updated my whole distribution to dig into steve's error)

[jdhenshaw]

Just wanted to touch base on this again, because I was unsure as to whether anything needs to be implemented. See the following line:

scousepy/scousepy/parallel_map.py

Line 99 in 444e572

return list(results)

Can you let me know if this is still an issue or if i can close?

[keflavich]

I think this is still an issue but I can't investigate again this week or next.