Cuda cannot be disabled

[jackmiller2003]

Hey very quick little issue.

In the current version of main, cuda cannot be disabled for run_ppo.py. If one looks at utils.py we have:

parser.add_argument(
        "--cuda",
        action="store_true",
        default=True,
        help="if toggled, cuda will be enabled by default",
    )

Which is always true no matter how one uses it.

Here's the link: https://github.com/jbloomAus/DecisionTransformerInterpretability/blob/main/src/ppo/utils.py#L42C5-L47C6.

[jbloomAus]

Ahh apologies for this. This was on my to do list for a long time. Not actively working on this currently but if you make a PR, I'll accept it.

…

On Mon, Nov 27, 2023, 10:36 AM Jack Miller ***@***.***> wrote: Hey very quick little issue. In the current version of main, cuda cannot be disabled for run_ppo.py. If one looks at utils.py we have: parser.add_argument( "--cuda", action="store_true", default=True, help="if toggled, cuda will be enabled by default", ) Which is always true no matter how one uses it. Here's the link: https://github.com/jbloomAus/DecisionTransformerInterpretability/blob/main/src/ppo/utils.py#L42C5-L47C6 . — Reply to this email directly, view it on GitHub <#106>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQPMYZZSR7PHI56577QGJGLYGRUJTAVCNFSM6AAAAAA73ZSJ22VHI2DSMVQWIX3LMV43ASLTON2WKOZSGAYTCOJXGU3TEMY> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[jackmiller2003]

No worries. Let me whip one up. Actually @jbloomAus, I think I would need access rights. No worries if this cannot be done as, after all, it's quite a minor change.

Best, Jack.

[jbloomAus]

Hi jack, you don't need access rights to submit a pull request:)