Bring back the success checks in usershell/localusergroupshell

[GieltjE]

Couldn't something like this fix the success check (it is language invariant), :

        public (ICollection<PSObject> result, Boolean success) Execute(String scriptFullPath, ICollection<CommandParameter> parameters, Boolean ignoreErrorStream = false)
        {
            String script = _embededFileReader.Read(scriptFullPath);

            using (Runspace runspace = RunspaceFactory.CreateRunspace())
            {
                runspace.Open();

                using (Pipeline pipeline = runspace.CreatePipeline())
                {
                    pipeline.Commands.Add(CreateCommand(parameters, script));

                    Collection<PSObject> results = pipeline.Invoke();

                    if (!ignoreErrorStream)
                    {
                        ThrowFromErrorStream(pipeline);
                    }

                    return (results, !pipeline.HadErrors);
                }
            }
        }

[jarzynam]

Thanks @GieltjE, for the asset, hope my library is somehow helpful for you. Could you explain a bit more what kind of problem we can solve with this fix?

Actually this method is throwing an error if pipline.HadErrors = true, except you set the flag ignoreErrorStream to true. So the feedback about errors has been provided.

[GieltjE]

The functions that rely on this function used to throw exceptions if someting went wrong, which is a bit more verbose than checking if it had errors after every operation.

[jarzynam]

Good point - I am including it in my plan