Skip to content

Increase limits (or remove) detection of 'Shift too big' condition #81

@jareff-g

Description

@jareff-g

Is your feature request related to a problem? Please describe.
When the displacement of a frame with regard to the template position is too big , an warning message ('shift too big') is logged, and frame is left as-is.

Describe the solution you'd like
After checking a specific case provided via discord (with sample frames), I see that even in cases of badly captured frames (sprocket hole not well detected) the calculated displacement might still be better than leaving the frame as is.

Describe alternatives you've considered
There are two alternatives here:

  • Increase the limits for a shift to be categorized as too big from the current values (Horiz. 150, Vert. 350) to higher ones (Vert. 1000, no treally needed for horizontal as it cannot realistically move more than the current 150 pixels)
  • Remove the detection of shift too big (might not be ideal, as in case of wrong template detection it can still be useful)

Additional context
NA

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions