Can't build on (Arch Linux, Async_ssl (v0.17.0-1 or 6fb6fcc) , OCaml 5.2.1)

[glyh]

Here's the error log

File "src/dune", line 25, characters 9-28:
25 |   (names ffi_generated_stubs)
              ^^^^^^^^^^^^^^^^^^^
ffi_generated_stubs.c: In function ‘async_ssl_stub_57_BN_hex2bn’:
ffi_generated_stubs.c:379:25: error: passing argument 1 of ‘BN_hex2bn’ from incompatible pointer type [-Wincompatible-pointer-types]
  379 |    int x260 = BN_hex2bn(x258, x259);
      |                         ^~~~
      |                         |
      |                         void **
In file included from /usr/include/openssl/params.h:16,
                 from /usr/include/openssl/indicator.h:18,
                 from /usr/include/openssl/core_dispatch.h:16,
                 from /usr/include/openssl/evp.h:28,
                 from /usr/include/openssl/x509.h:29,
                 from /usr/include/openssl/ssl.h:32,
                 from ffi_generated_stubs.c:2:
/usr/include/openssl/bn.h:346:24: note: expected ‘BIGNUM **’ {aka ‘struct bignum_st **’} but argument is of type ‘void **’
  346 | int BN_hex2bn(BIGNUM **a, const char *str);
      |               ~~~~~~~~~^
ffi_generated_stubs.c: In function ‘async_ssl_stub_86_SSL_get0_alpn_selected’:
ffi_generated_stubs.c:574:33: error: passing argument 2 of ‘SSL_get0_alpn_selected’ from incompatible pointer type [-Wincompatible-pointer-types]
  574 |    SSL_get0_alpn_selected(x397, x398, x399);
      |                                 ^~~~
      |                                 |
      |                                 char **
/usr/include/openssl/ssl.h:848:67: note: expected ‘const unsigned char **’ but argument is of type ‘char **’
  848 | void SSL_get0_alpn_selected(const SSL *ssl, const unsigned char **data,
      |                                             ~~~~~~~~~~~~~~~~~~~~~~^~~~

[tiash]

it looks like you're trying to build a very old version of Async_ssl (v0.14.0 from 2020).

I believe this was already fixed in v0.17.0-1
https://opam.ocaml.org/packages/async_ssl/async_ssl.v0.17.0-1/

[glyh]

I'm using OCaml 4.14, so I'll have to backport this, right?

[glyh]

I reattempted with a newer version and updated the issue description

[tiash]

Could you confirm exactly which version you were attempting to build. The type warning from your build log was fixed in 0.17.0**-1**.

[glyh]

Okay, let me retry this on v0.17.0-1

[glyh]

Looks like the dependency ppxlib.0.35.0 won't compile on Arch Linux now.

$ opam install ppxlib=0.35.0
The following actions will be performed:
=== install 1 package
  ∗ ppxlib 0.35.0

<><> Processing actions <><><><><><><><><><><><><><><><><><><><><><><><><><><><>
⬇ retrieved ppxlib.0.35.0  (cached)
[ERROR] The compilation of ppxlib.0.35.0 failed at "dune build -p ppxlib -j 7 @install".

#=== ERROR while compiling ppxlib.0.35.0 ======================================#
# context     2.3.0 | linux/x86_64 | ocaml.5.1.1 | https://opam.ocaml.org#34a3fc46c301a891122df75c17fef6b5358bd68f
# path        /tmp/abc/abc/_opam/.opam-switch/build/ppxlib.0.35.0
# command     ~/.opam/opam-init/hooks/sandbox.sh build dune build -p ppxlib -j 7 @install
# exit-code   1
# env-file    ~/.opam/log/ppxlib-1825162-3bfba0.env
# output-file ~/.opam/log/ppxlib-1825162-3bfba0.out
### output ###
# (cd _build/default && /tmp/abc/abc/_opam/bin/ocamlc.opt -w -9 -g -bin-annot -I astlib/.astlib.objs/byte -I /tmp/abc/abc/_opam/lib/ocaml-compiler-libs/common -I /tmp/abc/abc/_opam/lib/ocaml/compiler-libs -no-alias-deps -open Astlib__ -o astlib/.astlib.objs/byte/astlib__Ast_501.cmo -c -impl astlib/ast_501.pp.ml)
# File "astlib/ast_501.ml", lines 245-299, characters 2-44:
# Error: This variant or record definition does not match that of type
#          Parsetree.pattern_desc
#        An extra constructor, Ppat_effect, is provided in the original definition.



<><> Error report <><><><><><><><><><><><><><><><><><><><><><><><><><><><><><><>
┌─ The following actions failed
│ λ build ppxlib 0.35.0
└─ 
╶─ No changes have been performed

Also the reason I can't use ppxlib 0.36.0 is because:

$ opam instal async_ssl=v0.17.0.1 ppxlib=0.36.0
  * No agreement on the version of ppxlib:
    - async_ssl >= v0.17.0-1 → ppx_optcomp >= v0.17 → ppxlib < 0.36.0
    - ppxlib >= 0.36.0

[glyh]

I tried to compile on 6fb6fcc, here's the result

File "src/ssl.ml", lines 698-918, characters 0-3:
698 | module%test _ = struct
699 |   let pipe_to_string reader = Pipe.to_list reader >>| String.concat
700 | 
701 |   let check_closed p name =
702 |     if not (Pipe.is_closed p) then failwith (name ^ " was left open.")
...
915 |     in
916 |     Thread_safe.block_on_async_exn run_bench
917 |   ;;
918 | end
Error: value expected
File "src/dune", line 25, characters 9-28:       
25 |   (names ffi_generated_stubs)
              ^^^^^^^^^^^^^^^^^^^
ffi_generated_stubs.c: In function ‘async_ssl_stub_57_BN_hex2bn’:
ffi_generated_stubs.c:379:25: error: passing argument 1 of ‘BN_hex2bn’ from incompatible pointer type [-Wincompatible-pointer-types]
  379 |    int x260 = BN_hex2bn(x258, x259);
      |                         ^~~~
      |                         |
      |                         void **
In file included from /usr/include/openssl/params.h:16,
                 from /usr/include/openssl/indicator.h:18,
                 from /usr/include/openssl/core_dispatch.h:16,
                 from /usr/include/openssl/evp.h:28,
                 from /usr/include/openssl/x509.h:29,
                 from /usr/include/openssl/ssl.h:32,
                 from ffi_generated_stubs.c:2:
/usr/include/openssl/bn.h:346:24: note: expected ‘BIGNUM **’ {aka ‘struct bignum_st **’} but argument is of type ‘void **’
  346 | int BN_hex2bn(BIGNUM **a, const char *str);
      |               ~~~~~~~~~^
ffi_generated_stubs.c: In function ‘async_ssl_stub_86_SSL_get0_alpn_selected’:
ffi_generated_stubs.c:574:33: error: passing argument 2 of ‘SSL_get0_alpn_selected’ from incompatible pointer type [-Wincompatible-pointer-types]
  574 |    SSL_get0_alpn_selected(x397, x398, x399);
      |                                 ^~~~
      |                                 |
      |                                 char **
/usr/include/openssl/ssl.h:848:67: note: expected ‘const unsigned char **’ but argument is of type ‘char **’
  848 | void SSL_get0_alpn_selected(const SSL *ssl, const unsigned char **data,
      |                                             ~~~~~~~~~~~~~~~~~~~~~~^~~~
File "src/initialize.ml", line 18, characters 33-35:
18 |     Set_once.set_exn initialized ();
                                      ^^
Error: This expression should not be a unit literal, the expected type is
       Core__.Source_code_position.t
File "src/ffi__library_must_be_initialized.ml", lines 147-150, characters 6-73:
147 | ......failwiths
148 |         "Could not set session id context."
149 |         (`Return_value x, `Errors (get_error_stack ()))
150 |         [%sexp_of: [ `Return_value of int ] * [ `Errors of string list ]]
Error: This expression has type here:Lexing.position -> 'a
       but an expression was expected of type unit
  Hint: This function application is partial,
  maybe some arguments are missing.

[glyh]

I would like to help if desired. Could you tell me what's the workflow for updating bindings? Thanks :)

[whitebear555555]

The same problem on arch

[glyh]

Also, I think a nice once forever solution is statically linking