-
Notifications
You must be signed in to change notification settings - Fork 4
Create containedIn(appGroup:) for searching #12
Description
Currently we have a single containedIn(keychainGroup: String) on the KeychainQuerying protocol. This single entry point means the developer needs to understand the difference between App Groups and Keychain Access Groups and for KAG needs to send in teamID.keychainGroup instead of simply keychainGroup.
I propose changing this to having two methods .containedIn(appGroup: String) and .containedIn(teamID: String, keychainAccessGroup: String) to match the methods in the ItemSecurity type.
The existing containedIn(keychainGroup: String) would be marked deprecated with a note to use one or the other of the new methods without a simple FixIt. This deprecation strategy will hopefully cause the developer to think about which of the new methods they want to use instead of defaulting to perhaps the incorrect one.