From 50daf9394a97e166efa60dd6d3a7249c482a75fc Mon Sep 17 00:00:00 2001 From: BrennaManning Date: Tue, 28 Mar 2017 15:59:24 -0400 Subject: [PATCH 1/3] cat app feedback --- homework2/feedback.txt | 25 +++++++++++++++++++++++++ homework2/routes/index.js | 4 ++++ homework2/views/cats.handlebars | 5 ++++- 3 files changed, 33 insertions(+), 1 deletion(-) create mode 100644 homework2/feedback.txt diff --git a/homework2/feedback.txt b/homework2/feedback.txt new file mode 100644 index 00000000..77a3e416 --- /dev/null +++ b/homework2/feedback.txt @@ -0,0 +1,25 @@ + +Homework Feedback for Cat App + + +Functionality: + +All tasks completed! Awesome job, and your app appears to be bug free. + +Completion: (20/20) + +Bug Free: (10/10) + + +Quality: + +Your code was well organized and commented! It was very clear and readable. +You followed good coding practices throughout! + +Good Coding Practices: (10/10) + +Readability: (10/10) + + +Summary: +It was very sad when the cats were murdered, but great job on this homework! Everything is functional and well written. You seem to have had a great understanding of how everything fit together. (50/50). \ No newline at end of file diff --git a/homework2/routes/index.js b/homework2/routes/index.js index 9a76f486..dff84c08 100644 --- a/homework2/routes/index.js +++ b/homework2/routes/index.js @@ -81,3 +81,7 @@ module.exports.createCat = createCat; module.exports.listCats = listCats; module.exports.deleteCat = deleteCat; module.exports.sortCats = sortCats; + + + +// Great use of sort functions! Your code is clear, well commented, and readable! \ No newline at end of file diff --git a/homework2/views/cats.handlebars b/homework2/views/cats.handlebars index e7092359..484d8059 100644 --- a/homework2/views/cats.handlebars +++ b/homework2/views/cats.handlebars @@ -18,5 +18,8 @@ {{/if}} {{#if deleted}} -

{{deleted.name}} age {{deleted.age}} was murdered

+

{{deleted.name}} age {{deleted.age}} was murdered

{{/if}} + + +{{!-- {{ This templating was nice! Keeping everything in a table was good visually.}} --}} \ No newline at end of file From 82b185529ec509316c85948a8d665826b1bf7d1d Mon Sep 17 00:00:00 2001 From: BrennaManning Date: Tue, 28 Mar 2017 16:36:17 -0400 Subject: [PATCH 2/3] Update feedback.txt --- homework2/feedback.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/homework2/feedback.txt b/homework2/feedback.txt index 77a3e416..081c7241 100644 --- a/homework2/feedback.txt +++ b/homework2/feedback.txt @@ -1,5 +1,5 @@ -Homework Feedback for Cat App +**Homework Feedback for Cat App** Functionality: @@ -22,4 +22,4 @@ Readability: (10/10) Summary: -It was very sad when the cats were murdered, but great job on this homework! Everything is functional and well written. You seem to have had a great understanding of how everything fit together. (50/50). \ No newline at end of file +It was very sad when the cats were murdered, but great job on this homework! Everything is functional and well written. You seem to have had a great understanding of how everything fits together. (50/50). From 110e50b81c381809c82b48f2d0b2476dbc878f9f Mon Sep 17 00:00:00 2001 From: BrennaManning Date: Tue, 28 Mar 2017 16:37:00 -0400 Subject: [PATCH 3/3] Update cats.handlebars --- homework2/views/cats.handlebars | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/homework2/views/cats.handlebars b/homework2/views/cats.handlebars index 484d8059..cdd1480c 100644 --- a/homework2/views/cats.handlebars +++ b/homework2/views/cats.handlebars @@ -18,8 +18,8 @@ {{/if}} {{#if deleted}} -

{{deleted.name}} age {{deleted.age}} was murdered

+

{{deleted.name}} age {{deleted.age}} was murdered

{{/if}} -{{!-- {{ This templating was nice! Keeping everything in a table was good visually.}} --}} \ No newline at end of file +{{!-- {{ This templating was nice! Keeping everything in a table was good visually.}} --}}