BUI Banking module sometimes disallows filling bank

[esotericist]

In addition to #21's fourth item still being extant (bank UI not refreshing until you switch views), I'm finding that frequently I can't fill the last slot of my bank when using the BUI banking module.

I have a 100 slot capacity in my bank presently, but I can't sometimes put a hundredth item in there when it's showing 99/100. I can't find any particular pattern to it as of yet.

I've confirmed it isn't the case of it showing 99 when there's really 100 in there: if I disable the banking module then access the banker, I can immediately deposit an item.

[trentapple]

I noticed this issue as well (we still need to add a more obvious alert for when the bank is full if you attempt to deposit something). Also making it refresh the counts when depositing or withdrawing.

While working in the area of the code it wouldn't be difficult to make the bank capacity text display as red (or similar) when the bank is full (e.g. 240/240).

[esotericist]

To update on this, I'm sometimes also not allowed to move things into the bank using the BUI banking module when there's already stackable items of the same type in the bank.

e.g. trying to move 3 rawhide into the bank where there's 17 rawhide stored.

This part of the problem seems to be the BUI banking module isn't even attempting to stack items with like in the bank, the way the vanilla banking interface does. I'm finding I have to make room in the bank, move items over, then do a "restack all" on the bank view.

I'm still not sure why I sometimes can't move an item into the bank when there's one empty slot, though; it's compounding the above since I often have to have multiple empty bank slots in order to move things into the bank that there's already a quantity of. This is resulting in a lot of back-and-forth that shouldn't have to happen.

[esotericist]

Addendum: I just had a situation where I had 5 empty slots in the bank, couldn't move 25 sanded maple over until I made yet more empty space.

I don't have clear notions how to troubleshoot this, because lua is not a language I work with well (I was blindly flailing in the dark for my inventory module fix), so am resorting to just using the vanilla interface for the time being. :(