Binary Ninja dev channel raises warnings when creating comments

[austin-ralls-cs]

banjo/binaryview.py

Lines 110 to 122 in 5065477

	for try_item in method.code.tries:
	self.bv.set_comment_at(
	off + try_item.start_addr * 2,
	f":try_start_{try_item.start_addr:x}",
	)
	self.bv.set_comment_at(
	off + try_item.start_addr * 2 + try_item.insn_count * 2,
	f":try_end_{try_item.start_addr+try_item.insn_count:x}",
	)
	self.bv.set_comment_at(
	off + try_item.start_addr * 2 + try_item.insn_count * 2,
	f"{try_item.handler}",
	)

There are no issues in 5.0.7648 (e79b961f) but there are warnings in 5.1.7851-dev. From a quick glance, it seems like it still adds comments (for now) even with warnings.

Reported by @utkonos in binja Slack. Mason said that workflows are the recommend way to do this, but Vector35/binaryninja-api#7051 was created for the current method (I think?).

[utkonos]

@austin-ralls-cs hello! this plugin is really helpful. I'm working on a few contributions. I wanted to get my ducks in a row before opening an issue, but you're really on top of it!

[utkonos]

I think there is more that using a workflow will fix. I notice that every time I open a database, there are a series of warnings.

In addition to warnings, the changed database dot appears. This indicates that something has changed and needs to be saved. I still need to dig into it, but I think there is some code running every time the binaryview is opened whereas it should be run once during analysis workflow and then only again on reanalysis (or when you open in a new version of binary ninja).

[utkonos]

And looking at those warnings, I think that all the logging in the plugin can be sent to a dedicated logger instance that uses "Banjo" as the logger name. Then any logging that occurs will have "Banjo" appear there on the left of each log message rather than "Default"

https://api.binary.ninja/binaryninja.log-module.html#binaryninja.log.Logger