Startup delay on Purpur 1.21.5

[Strahilchu]

Huge delay during startup as the plugin loads data from players, its 42 seconds pause. Didn't do this on 1.21.4

[Strahilchu]

A lot of lag when processing stats as well

[Strahilchu]

In version 1.21.5 of the plugin the issue remains, please investigate, no error codes, just seems to eat up the IO

[Artemis-the-gr8]

Hmm, odd. As far as I can tell, it doesn't do this on Paper, so it might be a Purpur specific issue.
Is there anything in the logs? What happens if you set the debug-level to 2 in the PlayerStats config, does that give more info?

Edit: I'm trying to replicate your issue, but even on Purpur it's fine for me. Can you give me some more info? What exact Purpur version are you on, how many players are loaded, and do you have other plugins that might interfere in some way?

[Strahilchu]

latest purpur as of this time 1.21.5-2431-eca7806 (MC: 1.21.5)
plugin is loading over 4000 player stats. Nothing in the logs, just maxes out the cpu usage when adding things to the cache since i use stats with ajlb and the playerstats placeholder.

I don't think I have any plugins that interfere and when I remove PlayerStats the issue goes away completely. I'll try to figure out more

[Strahilchu]

Startup delay seems to have disappeared now but there is a huge lag still with

[12:34:28 INFO]: [PlayerStatsExpansion] Storing CHEST_OPENED in the cache...
[12:34:28 INFO]: [PlayerStatsExpansion] Storing SLEEP_IN_BED in the cache...
[12:35:53 INFO]: [PlayerStatsExpansion] Storing KILL_ENTITY in the cache...
[12:35:55 INFO]: [PlayerStatsExpansion] Storing WALK_ONE_CM in the cache...
[12:35:55 INFO]: [PlayerStatsExpansion] Storing CROUCH_ONE_CM in the cache...
[12:35:55 INFO]: [PlayerStatsExpansion] Storing SPRINT_ONE_CM in the cache...
[12:35:55 INFO]: [PlayerStatsExpansion] Storing FLY_ONE_CM in the cache...
[12:35:55 INFO]: [PlayerStatsExpansion] Storing PLAY_ONE_MINUTE in the cache...
[12:35:55 INFO]: [PlayerStatsExpansion] Storing DEATHS in the cache...
[12:35:55 INFO]: [PlayerStatsExpansion] Storing FISH_CAUGHT in the cache...
[12:35:55 INFO]: [PlayerStatsExpansion] Storing SWIM_ONE_CM in the cache...
[12:35:55 INFO]: [PlayerStatsExpansion] Storing ANIMALS_BRED in the cache...

for the leaderboards i have in holograms, these used to load very quickly, but now nearly crash the server. Not sure what's different

[Strahilchu]

still struggling to narrow down but
[PlayerStats] Loaded 4374 offline players (31660ms)

I get this a lot and ofc the expansion nearly crashes the game now when loading leaderboard stats (it never did this before 1.21.5)

[13:16:39 INFO]: ℹ Server Plugins (43):
[13:16:39 INFO]: Paper Plugins (1):
[13:16:39 INFO]: - nightcore
[13:16:39 INFO]: Bukkit Plugins (42):
[13:16:39 INFO]: - AdvancedAntiVPN, ajLeaderboards, AxSellwands, AxVaults, BestTools, BigDoors, BottledExp, ChestShop, ChestSort, CMI
[13:16:39 INFO]: CMILib, CommandPanels, CoreProtect, DiscordSRV, DrawOnMap, dynmap, Dynmap-WorldGuard, Elevator, ExcellentCrates, HeadDatabase
[13:16:39 INFO]: Jobs, LuckPerms, mcMMO, MobFarmManager, NoChatReports, packetevents, Pl-Hide-Pro, PlaceholderAPI, PlayerStats, Quests
[13:16:39 INFO]: RegionClaimPlus, SafariNet, ShopGUIPlus, ShopGUIPlus-SellGUI, TreeFeller, TryMe, Vault, Vehicles, VeinMiner, Vulcan
[13:16:39 INFO]: WorldEdit, WorldGuard

[Artemis-the-gr8]

At server startup, do you see the message "[PlayerStats] Enabled PlayerStats!" before the message with how many offline players it has loaded, and can people join the server already? PlayerStats loads all playerdata on a separate thread, so unless Purpur is doing something weird, it isn't possible for it to suspend the bootup of the server. It still tells you how long it took to load (mainly because I wanted a way to monitor how long it takes), but during that time the server should continue to load everything else.

I've been thinking about this issue, and it could be caused by several different things. I've listed them, and included the questions that need to be answered to pinpoint further what it is:

1. PlayerStats itself. I've reviewed the changes I made this last update, and I didn't change anything about the way it retrieves data or calculates things, so this would be odd. To confirm, you could temporarily change to PlayerStats v2.3 instead of v2.4 and see if that one gives the same problems. On v2.3 the stat sharing and hover-text should be broken for Minecraft 1.21.5, but all other features should still work, and it should give more information on whether a change in PlayerStats is causing this or not.
2. The leaderboard plugin you're using. When I made the expansion, I kept in mind that some leaderboard plugins like to refresh 20 times a second, which might cause a lot of strain if PlayerStats has to recalculate all top statistics that often, so I made it calculate only once. After the initial calculation, it stores the results and dynamically updates only the statistics for players that are online. Still, the initial calculation is also done asynchronously, so it shouldn't cause the server to freeze. The placeholders should say "Processing..." until the results are in, and allow the server to continue in the mean time. Are you experiencing similar lag spikes when players are executing top or server stat commands in chat? If not, it's likely the leaderboard plugin and not PlayerStats causing the issue. And what kind of lag are you noticing? If you want to be sure, you could temporarily install a different leaderboard plugin (like DecentHolograms) and see if that one has the issue too.
3. Purpur itself. I don't have a lot of experience with Purpur, so I can't do much about this one.
4. Minecraft 1.21.5. It's possible something changed with the update that makes looking up playerdata a lot heavier than it used to be. I can't do much about this one right now either, except hope that it gets fixed in later updates. I don't know if you have a testserver you could use to run 1.21.4 with the latest PlayerStats update. If that doesn't give any issues, it's likely a change in Minecraft that caused this, not PlayerStats.