From 73d2dc219a1d25ac7ff0f394f2d2a24b673ea23d Mon Sep 17 00:00:00 2001 From: Revivius Date: Mon, 5 Oct 2020 22:14:38 +0300 Subject: [PATCH] Update Database.java MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Selam; Her seferinde bağlantı açılması Encasulation Tek satır bile olsa {...} şeklimde blok açılması --- src/main/java/Database.java | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/main/java/Database.java b/src/main/java/Database.java index b44a68e..87830d1 100644 --- a/src/main/java/Database.java +++ b/src/main/java/Database.java @@ -8,6 +8,8 @@ * @author ismet abacı */ public class Database { + // GG: + // Neden private değiller ? final static Logger logger = Logger.getLogger(String.valueOf(MyThread.class)); String url ; String databaseName ; @@ -33,7 +35,11 @@ public Database(String url,String databaseName,String userName, String password) public void insertIntoDatabase(JSONObject msg){ try{ String tableName = (String) msg.get("priority"); //get table name according to the message's priority + // GG: + // Tek satır da olsa blok açılmalı if (tableName == null) return; + // GG: + // Her seferinde bağlantı açmak mantıklı değil. Başka ne yöntem kullanılabilir ? connect = DriverManager.getConnection(url + databaseName +"?user="+ userName +"&password=" + password); //WARNING: I used xampp for the db Connection String sql = "insert into " + tableName + " (id,sender,receiver,subject,cc,message,priority) values (default, ?, ?, ?, ? , ?, ?);"; preparedStatement = connect.prepareStatement(sql); @@ -44,7 +50,10 @@ public void insertIntoDatabase(JSONObject msg){ preparedStatement.setString(5, msg.get("message").toString()); preparedStatement.setString(6, msg.get("priority").toString()); preparedStatement.executeUpdate(); + }catch(Exception e){ + // GG: + // Indent kaymış. logger.warning("Error on client-db conn -> " + e); } }