From f6e5f25402ddbc3b822331b0692990618fe3a9a8 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Fri, 21 Oct 2022 00:13:56 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- Tutorial/chatterbot/trainers.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/Tutorial/chatterbot/trainers.py b/Tutorial/chatterbot/trainers.py index f4d855e..0c5f868 100644 --- a/Tutorial/chatterbot/trainers.py +++ b/Tutorial/chatterbot/trainers.py @@ -303,7 +303,26 @@ def track_progress(members): print('Extracting {}'.format(member.path)) with tarfile.open(file_path) as tar: - tar.extractall(path=self.data_directory, members=track_progress(tar)) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, path=self.data_directory, members=track_progress(tar)) self.logger.info('File extraction complete')