Some annotations with hrefs not clickable

[nate-kean]

Almost none of the annotations in Rewind YouTube Style 2012 are clickable, even though their data contains a URL.

As an example, on this screen, the annotations over "PSY" and "WalkOffTheEarth" are clickable, but the ones for the "YouTube Rewind 2012" message and "Watch the Behind the Scenes" are not:

Here is Psy's annotation which works as expected:

<annotation id="annotation_855985" type="highlight" log_data="a-id=annotation_855985&amp;a-type=3&amp;a-v=iCkYw3cRwLo&amp;ei=PLs9XJSRMOGp8QPwuq64Bg&amp;l-class=3&amp;link=http%3A%2F%2Fwww.youtube.com%2Fuser%2Fofficialpsy&amp;xble=1" itct="">
  <segment>
    <movingRegion type="rect">
      <rectRegion x="54.68800" y="9.16700" w="40.00000" h="40.55600" t="0:03:21.6"/>
      <rectRegion x="54.68800" y="9.16700" w="40.00000" h="40.55600" t="0:03:27.0"/>
    </movingRegion>
  </segment>
  <appearance bgColor="16777215" highlightWidth="3" borderAlpha="0.25"/>
  
  <action type="openUrl" trigger="click">
    <url target="new" value="https://www.youtube.com/user/officialpsy?annotation_id=annotation_855985&amp;ei=PLs9XJSRMOGp8QPwuq64Bg&amp;feature=iv&amp;src_vid=iCkYw3cRwLo" link_class="3"/>
  </action>

</annotation>

and this is the Behind the Scenes annotation, which is not clickable even though its data has an openURL click action:

<annotation id="annotation_817107" type="highlight" log_data="a-id=annotation_817107&amp;a-type=3&amp;a-v=iCkYw3cRwLo&amp;ei=PLs9XJSRMOGp8QPwuq64Bg&amp;l-class=12&amp;link=http%3A%2F%2Fgoo.gl%2FGkU8M&amp;xble=1" itct="">
  <segment>
    <movingRegion type="rect">
      <rectRegion x="11.87500" y="56.94400" w="29.84400" h="30.00000" t="0:03:21.6"/>
      <rectRegion x="11.87500" y="56.94400" w="29.84400" h="30.00000" t="0:04:06.7"/>
    </movingRegion>
  </segment>
  <appearance bgColor="16777215" highlightWidth="3" borderAlpha="0.25"/>
  
  <action type="openUrl" trigger="click">
    <url target="new" value="http://goo.gl/GkU8M" link_class="12"/>
  </action>

</annotation>

I think the problem is that the parser is ignoring goo.gl URLs.

annotationlib/parser/index.ts

Line 321 in 3121159

if (href.startsWith("https://www.youtube.com/")) {

[isaackd]

Appreciate you looking into this! I agree that the check should be removed. Clients using the renderer can easily decide whether they want to redirect outside youtube.com

[isaackd]

Fixed in ce8ea7e. I'll release an update to the extension including this change as soon as I can