-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Open
Labels
kind/maintenanceWork required to avoid breaking changes or harm to project's status quoWork required to avoid breaking changes or harm to project's status quokind/testTesting workTesting worktopic/rpc-apiIssues related to Kubo RPC API at /api/v0Issues related to Kubo RPC API at /api/v0
Milestone
Description
Right now, js-ipfs runs tests that ensure js-ipfs-http-client works against the last go-ipfs release.
This has a downside of being a late feedback loop – if go-ipfs breaks something in the HTTP client for JS, we learn about it too late.
We should run js-ipfs interface tests in go-ipfs CI to get early feedback and have time to fix any regressions.
Implementation details
- See how tests run js-ipfs – the matrix in https://github.com/ipfs/js-ipfs/blob/b5488cb3ef5ab7ea24b8b2275ffa8cfa4b7b7ed1/.github/workflows/test.yml#L230-L269
test:interface:http-gois what we want to run in go-ipfs repo (on every push, against binary built from go-ipfs HEAD)-
It chains through to this command which uses this file to configure the tests (e.g. skip the things that go-ipfs doesn't implement)
-
It just needs a little project making with a dependency on interface-ipfs-core for the tests and an equivalent of ipfs/test/utils/factory.js to configure the go-ipfs instance for running under node and ipfs/.aegir.js to configure it for running in the browser.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
kind/maintenanceWork required to avoid breaking changes or harm to project's status quoWork required to avoid breaking changes or harm to project's status quokind/testTesting workTesting worktopic/rpc-apiIssues related to Kubo RPC API at /api/v0Issues related to Kubo RPC API at /api/v0