Skip to content

Commands Library Upgrade #5664

@Stebalien

Description

@Stebalien

Given the amount of interest in updating commands-lib commands to the latest commands-lib version (and the recently fixed bugs in MakeTypedEncoder), let's have a meta-issue.

General suggestions:

  1. Prefer MakeTypedEncoder, it removes some boilerplate.
  2. Old encoders tended to return NewReader(someByteBufferOrString). In new code, prefer writing directly to the provided writer instead of first building up a temporary buffer/string.

Please comment below with the commands you're planning on fixing (just that).
They'll be checked off when actually fixed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions