-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Closed
Labels
topic/metaTopic metaTopic meta
Description
Given the amount of interest in updating commands-lib commands to the latest commands-lib version (and the recently fixed bugs in MakeTypedEncoder), let's have a meta-issue.
General suggestions:
- Prefer
MakeTypedEncoder, it removes some boilerplate. - Old encoders tended to return
NewReader(someByteBufferOrString). In new code, prefer writing directly to the provided writer instead of first building up a temporary buffer/string.
Please comment below with the commands you're planning on fixing (just that).
They'll be checked off when actually fixed.
- bitswap ledger commands/bitswap: use new cmds lib #5676
- bitswap reprovide commands/bitswap: use new cmds lib #5676
- bitswap wantlist commands/bitswap: use new cmds lib #5676
- bootstrap add commands/boostrap: use new cmds #5678
- bootstrap add default commands/boostrap: use new cmds #5678
- bootstrap list commands/boostrap: use new cmds #5678
- bootstrap rm commands/boostrap: use new cmds #5678
- bootstrap rm all commands/boostrap: use new cmds #5678
- config edit - refactor(cmds): use new cmds #5659
- config profile - refactor(cmds): use new cmds #5659
- config profile apply - refactor(cmds): use new cmds #5659
- config replace - refactor(cmds): use new cmds #5659
- config show - refactor(cmds): use new cmds #5659
- dag get - cmds/dag: use new cmds lib #5662
- dag put - cmds/dag: use new cmds lib #5662
- dag resolve - cmds/dag: use new cmds lib #5662
- dht findpeer commands/dht: use new cmds lib #5671
- dht findprovs commands/dht: use new cmds lib #5671
- dht get commands/dht: use new cmds lib #5671
- dht provide commands/dht: use new cmds lib #5671
- dht put commands/dht: use new cmds lib #5671
- dht query commands/dht: use new cmds lib #5671
- diag cmds - refactor(cmds): use new cmds #5659
- diag cmds clear - refactor(cmds): use new cmds #5659
- diag cmds set-time - refactor(cmds): use new cmds #5659
- diag sys - refactor(cmds): use new cmds #5659
- dns - refactor(cmds): use new cmds lib in version, tar and dns #5650
- file ls cmds/file: use new cmds lib #5756
- files chcid commands/files: use new cmds #5665
- files cp commands/files: use new cmds #5665
- files flush commands/files: use new cmds #5665
- files ls commands/files: use new cmds #5665
- files mkdir commands/files: use new cmds #5665
- files mv commands/files: use new cmds #5665
- files read commands/files: use new cmds #5665
- files rm commands/files: use new cmds #5665
- filestore dups commands/filestore: use new cmds lib #5673
- filestore verify commands/filestore: use new cmds lib #5673
- log level - refactor(cmds): use new cmds #5659
- log ls - refactor(cmds): use new cmds #5659
- log tail - refactor(cmds): use new cmds #5659
- ls - Add --stream option to
lscommand #5611 commands/ls: use new cmds lib #5663 - mount - refactor(cmds): use new cmds #5659
- object data commands/object: use new cmds #5666
- object diff commands/object: use new cmds #5666
- object get commands/object: use new cmds #5666
- object links commands/object: use new cmds #5666
- object new commands/object: use new cmds #5666
- object patch add-link commands/object: use new cmds #5666
- object patch rm-link commands/object: use new cmds #5666
- object patch set-data commands/object: use new cmds #5666
- object put commands/object: use new cmds #5666
- object stat commands/object: use new cmds #5666
- p2p close commands/p2p: use new cmds lib #5672
- p2p forward commands/p2p: use new cmds lib #5672
- p2p listen commands/p2p: use new cmds lib #5672
- p2p ls commands/p2p: use new cmds lib #5672
- p2p stream close commands/p2p: use new cmds lib #5672
- p2p stream ls commands/p2p: use new cmds lib #5672
- pin add
- pin rm commands/pin: use new cmds lib #5674
- pin update commands/pin: use new cmds lib #5674
- pin verify commands/pin: use new cmds lib #5674
- ping Commands Library Upgrade #5664
- refs commands/refs: use new cmds #5679
- refs local commands/refs: use new cmds #5679
- repo fsck refact(cmd/repo): repo's sub cmds uses new cmd lib #5677
- repo verify refact(cmd/repo): repo's sub cmds uses new cmd lib #5677
- repo version refact(cmd/repo): repo's sub cmds uses new cmd lib #5677
- tar add - refactor(cmds): use new cmds lib in version, tar and dns #5650
- tar cat - refactor(cmds): use new cmds lib in version, tar and dns #5650
- update cmds/update: use new cmds lib #5730
- version - refactor(cmds): use new cmds lib in version, tar and dns #5650
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
topic/metaTopic metaTopic meta