Skip to content
This repository was archived by the owner on Jun 20, 2024. It is now read-only.
This repository was archived by the owner on Jun 20, 2024. It is now read-only.

Support DNSLink on ENS (move namesys defaults out of Kubo) #60

@lidel

Description

@lidel

Problem

bifrost-gateway must have feature and behavior parity with Kubo, but we have a bug around ENS:

Potential cause

Seems that we are running different namesys config than Kubo.

It should use the same set of defaultResolvers to support ENS and UD, as noted in the config docs, but *.eth resolution does not work atm.

Cleanup proposal

Move defaultResolvers to one of upstream libraries, and make them implicit default to avoid ENS failures like this one.

Option A: move to go-namesys (global)

This applies defaults to both DNSLinks and Multiaddrs, allowing use of *.eth in /dnsaddr too

Option B: move to go-libipfs/gateway (minimal, scoped to DNSLinks)

This would only apply to DNSLinks, but that is enough given the utility of ENS today (just DNSLinks).


@hacdias @aschmahmann Thoughts?

I feel (B) may be cleaner:

  • WithNameSystem allows users to pass custom resolvers
  • if no WithNameSystem is passed we apply defaultResolvers on the library level as implicit default

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions