Skip to content

Commit a8adabe

Browse files
authored
[tooling] Use optional in ImplicitDicts (#1314)
1 parent 0c68605 commit a8adabe

File tree

59 files changed

+399
-383
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

59 files changed

+399
-383
lines changed

monitoring/deployment_manager/systems/configuration.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from implicitdict import ImplicitDict
1+
from implicitdict import ImplicitDict, Optional
22

33
from monitoring.deployment_manager.systems.dss.configuration import DSS
44
from monitoring.deployment_manager.systems.test.configuration import Test
@@ -14,11 +14,11 @@ class KubernetesCluster(ImplicitDict):
1414

1515

1616
class DeploymentSpec(ImplicitDict):
17-
cluster: KubernetesCluster | None
17+
cluster: Optional[KubernetesCluster]
1818
"""Definition of Kubernetes cluster containing this deployment."""
1919

20-
test: Test | None
20+
test: Optional[Test]
2121
"""Test systems in this deployment."""
2222

23-
dss: DSS | None
23+
dss: Optional[DSS]
2424
"""DSS instance in this deployment."""
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
from implicitdict import ImplicitDict
1+
from implicitdict import ImplicitDict, Optional
22

33

44
class TestV1(ImplicitDict):
55
namespace: str = "test"
66

77

88
class Test(ImplicitDict):
9-
v1: TestV1 | None
9+
v1: Optional[TestV1]

monitoring/mock_uss/database.py

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,19 @@
11
import json
22

3-
from implicitdict import ImplicitDict, StringBasedDateTime, StringBasedTimeDelta
3+
from implicitdict import (
4+
ImplicitDict,
5+
Optional,
6+
StringBasedDateTime,
7+
StringBasedTimeDelta,
8+
)
49

510
from monitoring.monitorlib.errors import stacktrace_string
611
from monitoring.monitorlib.multiprocessing import SynchronizedValue
712

813

914
class PeriodicTaskStatus(ImplicitDict):
10-
last_execution_time: StringBasedDateTime | None = None
11-
period: StringBasedTimeDelta | None = None
15+
last_execution_time: Optional[StringBasedDateTime] = None
16+
period: Optional[StringBasedTimeDelta] = None
1217
executing: bool = False
1318

1419

@@ -43,7 +48,7 @@ class Database(ImplicitDict):
4348
periodic_tasks: dict[str, PeriodicTaskStatus]
4449
"""Tasks to perform periodically, by name"""
4550

46-
most_recent_periodic_check: StringBasedDateTime | None
51+
most_recent_periodic_check: Optional[StringBasedDateTime]
4752
"""Timestamp of most recent time periodic task loop iterated"""
4853

4954

monitoring/mock_uss/flights/database.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import json
22
from datetime import timedelta
33

4-
from implicitdict import ImplicitDict
4+
from implicitdict import ImplicitDict, Optional
55
from uas_standards.astm.f3548.v21.api import OperationalIntent
66

77
from monitoring.mock_uss.user_interactions.notifications import UserNotification
@@ -19,7 +19,7 @@ class FlightRecord(ImplicitDict):
1919

2020
flight_info: FlightInfo
2121
op_intent: OperationalIntent
22-
mod_op_sharing_behavior: MockUssFlightBehavior | None = None
22+
mod_op_sharing_behavior: Optional[MockUssFlightBehavior] = None
2323
locked: bool = False
2424

2525

monitoring/mock_uss/geoawareness/database.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import json
22

3-
from implicitdict import ImplicitDict
3+
from implicitdict import ImplicitDict, Optional
44
from uas_standards.eurocae_ed269 import ED269Schema
55
from uas_standards.interuss.automated_testing.geo_awareness.v1.api import (
66
CreateGeozoneSourceRequest,
@@ -17,8 +17,8 @@ class ExistingRecordException(ValueError):
1717
class SourceRecord(ImplicitDict):
1818
definition: CreateGeozoneSourceRequest
1919
state: GeozoneSourceResponseResult
20-
message: str | None
21-
geozone_ed269: ED269Schema | None
20+
message: Optional[str]
21+
geozone_ed269: Optional[ED269Schema]
2222

2323

2424
class Database(ImplicitDict):
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
from implicitdict import ImplicitDict
1+
from implicitdict import ImplicitDict, Optional
22

33
ServiceProviderID = str
44

55

66
class DisplayProviderBehavior(ImplicitDict):
7-
always_omit_recent_paths: bool | None = False
8-
do_not_display_flights_from: list[ServiceProviderID] | None = []
7+
always_omit_recent_paths: Optional[bool] = False
8+
do_not_display_flights_from: Optional[list[ServiceProviderID]] = []

monitoring/mock_uss/ridsp/behavior.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from implicitdict import ImplicitDict
1+
from implicitdict import ImplicitDict, Optional
22
from uas_standards.astm.f3411.v19.api import RIDFlight
33

44
from monitoring.monitorlib.delay import sleep
@@ -8,10 +8,10 @@
88

99

1010
class ServiceProviderBehavior(ImplicitDict):
11-
switch_latitude_and_longitude_when_reporting: bool | None = False
12-
use_agl_instead_of_wgs84_for_altitude: bool | None = False
13-
use_feet_instead_of_meters_for_altitude: bool | None = False
14-
delay_flight_report_s: int | None = 0
11+
switch_latitude_and_longitude_when_reporting: Optional[bool] = False
12+
use_agl_instead_of_wgs84_for_altitude: Optional[bool] = False
13+
use_feet_instead_of_meters_for_altitude: Optional[bool] = False
14+
delay_flight_report_s: Optional[int] = 0
1515

1616

1717
def adjust_reported_flight(

monitoring/mock_uss/ridsp/database.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import json
22

3-
from implicitdict import ImplicitDict
3+
from implicitdict import ImplicitDict, Optional
44

55
from monitoring.monitorlib.multiprocessing import SynchronizedValue
66
from monitoring.monitorlib.rid_automated_testing import injection_api
@@ -14,7 +14,7 @@ class TestRecord(ImplicitDict):
1414

1515
version: str
1616
flights: list[injection_api.TestFlight]
17-
isa_version: str | None = None
17+
isa_version: Optional[str] = None
1818

1919
def __init__(self, **kwargs):
2020
kwargs["flights"] = [

monitoring/mock_uss/tracer/log_types.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import sys
44
from abc import abstractmethod
55

6-
from implicitdict import ImplicitDict, StringBasedDateTime
6+
from implicitdict import ImplicitDict, Optional, StringBasedDateTime
77

88
from monitoring.monitorlib.fetch import RequestDescription, summarize
99
from monitoring.monitorlib.fetch import rid as rid_fetch
@@ -124,7 +124,7 @@ def prefix_code() -> str:
124124
existing_subscription: rid_fetch.FetchedSubscription
125125
"""Subscription, as read from the DSS just before deletion."""
126126

127-
deleted_subscription: rid_mutate.ChangedSubscription | None
127+
deleted_subscription: Optional[rid_mutate.ChangedSubscription]
128128
"""Subscription returned from DSS upon deletion."""
129129

130130

@@ -214,7 +214,7 @@ def prefix_code() -> str:
214214
existing_subscription: scd_fetch.FetchedSubscription
215215
"""Subscription, as read from the DSS just before deletion."""
216216

217-
deleted_subscription: scd_mutate.MutatedSubscription | None
217+
deleted_subscription: Optional[scd_mutate.MutatedSubscription]
218218
"""Subscription returned from DSS upon deletion."""
219219

220220

@@ -270,7 +270,7 @@ class ObservationAreaImportError(TracerLogEntry):
270270
def prefix_code() -> str:
271271
return "import_obs_areas_error"
272272

273-
rid_subscriptions: rid_fetch.FetchedSubscriptions | None
273+
rid_subscriptions: Optional[rid_fetch.FetchedSubscriptions]
274274
"""Result of attempting to fetch RID subscriptions"""
275275

276276

monitoring/mock_uss/tracer/observation_areas.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from implicitdict import ImplicitDict
1+
from implicitdict import ImplicitDict, Optional
22

33
from monitoring.monitorlib.geotemporal import Volume4D
44
from monitoring.monitorlib.infrastructure import AuthSpec
@@ -45,7 +45,7 @@ class F3548ObservationArea(ImplicitDict):
4545
poll: bool
4646
"""This area observes by periodically polling for information."""
4747

48-
subscription_id: str | None = None
48+
subscription_id: Optional[str] = None
4949
"""The F3548 subscription ID established to provide observation via notifications."""
5050

5151

@@ -58,10 +58,10 @@ class ObservationArea(ImplicitDict):
5858
area: Volume4D
5959
"""Spatial-temporal area being observed."""
6060

61-
f3411: F3411ObservationArea | None = None
61+
f3411: Optional[F3411ObservationArea] = None
6262
"""How F3411 information is being observed (or not observed, if not specified)."""
6363

64-
f3548: F3548ObservationArea | None = None
64+
f3548: Optional[F3548ObservationArea] = None
6565
"""How F3548 information is being observed (or not observed, if not specified)."""
6666

6767
@property
@@ -75,12 +75,12 @@ def polls(self) -> bool:
7575
class F3411ObservationAreaRequest(ImplicitDict):
7676
"""How to observe F3411 activity."""
7777

78-
auth_spec: AuthSpec | None = None
78+
auth_spec: Optional[AuthSpec] = None
7979
"""If specified, use this auth spec when performing observation activities.
8080
8181
If not specified or blank, use auth spec provided on the command line."""
8282

83-
dss_base_url: str | None = None
83+
dss_base_url: Optional[str] = None
8484
"""If specified, use the DSS at this base URL when performing relevant observation activities.
8585
8686
If not specified or blank, use DSS URL provided on the command line."""
@@ -98,12 +98,12 @@ class F3411ObservationAreaRequest(ImplicitDict):
9898
class F3548ObservationAreaRequest(ImplicitDict):
9999
"""How to observe F3548 activity."""
100100

101-
auth_spec: AuthSpec | None = None
101+
auth_spec: Optional[AuthSpec] = None
102102
"""If specified, use this auth spec when performing observation activities.
103103
104104
If not specified or blank, use auth spec provided on the command line."""
105105

106-
dss_base_url: str | None = None
106+
dss_base_url: Optional[str] = None
107107
"""If specified, use the DSS at this base URL when performing relevant observation activities.
108108
109109
If not specified or blank, use DSS URL provided on the command line."""
@@ -127,10 +127,10 @@ class ObservationAreaRequest(ImplicitDict):
127127
area: Volume4D
128128
"""Spatial-temporal area that should be observed."""
129129

130-
f3411: F3411ObservationAreaRequest | None = None
130+
f3411: Optional[F3411ObservationAreaRequest] = None
131131
"""How to observe F3411 (NetRID) activity."""
132132

133-
f3548: F3548ObservationAreaRequest | None = None
133+
f3548: Optional[F3548ObservationAreaRequest] = None
134134
"""How to observe F3548 (strategic coordination, conformance monitoring, and constraints) activity."""
135135

136136
@property
@@ -168,7 +168,7 @@ class ImportObservationAreasRequest(ImplicitDict):
168168
area: Volume4D
169169
"""Spatial-temporal area containing subscriptions to be imported."""
170170

171-
f3411: RIDVersion | None = None
171+
f3411: Optional[RIDVersion] = None
172172
"""If specified, search for subscriptions using this F3411 version."""
173173

174174
f3548: bool = False

0 commit comments

Comments
 (0)