Skip to content

Commit 3a642ea

Browse files
committed
[probe] Validate extents time start before time end
1 parent dade5df commit 3a642ea

File tree

3 files changed

+37
-0
lines changed

3 files changed

+37
-0
lines changed

monitoring/prober/scd/test_constraint_simple.py

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,19 @@ def test_create_constraint_missing_time_end(ids, scd_api, scd_session):
123123
assert resp.status_code == 400, resp.content
124124

125125

126+
@for_api_versions(scd.API_0_3_17)
127+
@default_scope(SCOPE_CM)
128+
@depends_on(test_ensure_clean_workspace)
129+
def test_create_constraint_time_start_after_time_end(ids, scd_api, scd_session):
130+
req = _make_c1_request()
131+
e = req["extents"][0]
132+
t = e["time_end"]
133+
e["time_end"] = e["time_start"]
134+
e["time_start"] = t
135+
resp = scd_session.put(f"/constraint_references/{ids(CONSTRAINT_TYPE)}", json=req)
136+
assert resp.status_code == 400, resp.content
137+
138+
126139
@for_api_versions(scd.API_0_3_17)
127140
@depends_on(test_ensure_clean_workspace)
128141
def test_create_constraint(ids, scd_api, scd_session):

monitoring/prober/scd/test_operation_simple.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,18 @@ def test_create_op_missing_time_end(ids, scd_api, scd_session):
128128
assert resp.status_code == 400, resp.content
129129

130130

131+
@default_scope(SCOPE_SC)
132+
@depends_on(test_ensure_clean_workspace)
133+
def test_create_op_time_start_after_time_end(ids, scd_api, scd_session):
134+
req = _make_op1_request()
135+
e = req["extents"][0]
136+
time_end = e["time_end"]
137+
e["time_end"] = e["time_start"]
138+
e["time_start"] = time_end
139+
resp = scd_session.put(f"/operational_intent_references/{ids(OP_TYPE)}", json=req)
140+
assert resp.status_code == 400, resp.content
141+
142+
131143
@depends_on(test_ensure_clean_workspace)
132144
def test_create_op(ids, scd_api, scd_session, scd_session_cp, scd_session_cm):
133145
req = _make_op1_request()

monitoring/prober/scd/test_subscription_simple.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,18 @@ def test_sub_does_not_exist_query(ids, scd_api, scd_session):
9595
]
9696

9797

98+
@for_api_versions(scd.API_0_3_17)
99+
@default_scope(SCOPE_SC)
100+
def test_create_sub_time_start_after_time_end(ids, scd_api, scd_session):
101+
req = _make_sub1_req(scd_api)
102+
e = req["extents"]
103+
time_end = e["time_end"]
104+
e["time_end"] = e["time_start"]
105+
e["time_start"] = time_end
106+
resp = scd_session.put(f"/subscriptions/{ids(SUB_TYPE)}", json=req)
107+
assert resp.status_code == 400, resp.content
108+
109+
98110
@for_api_versions(scd.API_0_3_17)
99111
@default_scope(SCOPE_SC)
100112
def test_create_sub(ids, scd_api, scd_session):

0 commit comments

Comments
 (0)