[uss_qualifier/scenarios] Fix scenario phase transitions (#1375)

Author: BenjaminPelletier

monitoring/uss_qualifier/scenarios/astm/utm/dss/op_intent_ref_access_control.py

@@ -139,6 +139,7 @@ def run(self, context: ExecutionContext):
                 "clean_workspace",
                 "Could not clean up workspace, skipping scenario",
             )
+            self.end_test_case()
 
         self.end_test_scenario()
 

monitoring/uss_qualifier/scenarios/astm/utm/nominal_planning/solo_happy_path.py

@@ -6,4 +6,5 @@
 class SoloHappyPath(TestScenario):
     @deprecated(deprecated_in="0.26.0")
     def run(self, context):
-        pass
+        self.begin_test_scenario(context)
+        self.end_test_scenario()

monitoring/uss_qualifier/scenarios/scenario.py

@@ -554,6 +554,7 @@ def end_test_scenario(self) -> None:
     def go_to_cleanup(self) -> None:
         self._expect_phase(
             {
+                ScenarioPhase.NotStarted,
                 ScenarioPhase.ReadyForTestCase,
                 ScenarioPhase.ReadyForTestStep,
                 ScenarioPhase.RunningTestStep,

monitoring/uss_qualifier/scenarios/scenario_test/generic_test_scenario_test.py

@@ -518,7 +518,7 @@ def test_go_to_cleanup():
 
     # This is a list of step to do, in order, and if go_to_cleanup should works
     steps_and_result = [
-        ("nop", False),
+        ("nop", True),
         ("begin_test_scenario", True),
         ("begin_test_case", True),
         ("begin_test_step", True),