Skip to content

Commit 00635b1

Browse files
committed
[netrid] Fix misbehaviour tests by not using too large area for Unauthenticated / Incorrectly authenticated requests
1 parent f97c1d1 commit 00635b1

File tree

1 file changed

+1
-17
lines changed

1 file changed

+1
-17
lines changed

monitoring/uss_qualifier/scenarios/astm/netrid/common/misbehavior.py

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -85,22 +85,13 @@ def run(self, context: ExecutionContext):
8585

8686
self.begin_test_step("Invalid search area")
8787
self._poll_during_flights(
88-
[
89-
self._rid_version.max_diagonal_km * 1000
90-
- 100, # valid diagonal required for sps urls discovery
91-
],
9288
self._evaluate_and_test_too_large_area_requests,
9389
dict(),
9490
)
9591
self.end_test_step()
9692

9793
self.begin_test_step("Unauthenticated requests")
9894
self._poll_during_flights(
99-
[
100-
self._rid_version.max_diagonal_km * 1000 + 500, # too large
101-
self._rid_version.max_diagonal_km * 1000 - 100, # clustered
102-
self._rid_version.max_details_diagonal_km * 1000 - 100, # details
103-
],
10495
self._evaluate_and_test_authentication,
10596
{
10697
"auth": auth.NoAuth(aud_override=""),
@@ -112,11 +103,6 @@ def run(self, context: ExecutionContext):
112103

113104
self.begin_test_step("Incorrectly authenticated requests")
114105
self._poll_during_flights(
115-
[
116-
self._rid_version.max_diagonal_km * 1000 + 500, # too large
117-
self._rid_version.max_diagonal_km * 1000 - 100, # clustered
118-
self._rid_version.max_details_diagonal_km * 1000 - 100, # details
119-
],
120106
self._evaluate_and_test_authentication,
121107
{
122108
"auth": auth.InvalidTokenSignatureAuth(),
@@ -136,7 +122,6 @@ def _inject_flights(self):
136122

137123
def _poll_during_flights(
138124
self,
139-
diagonals_m: list[float],
140125
evaluation_func: Callable[
141126
[LatLngRect, Unpack[dict[str, auth.AuthAdapter | str]]], set[str]
142127
],
@@ -145,7 +130,6 @@ def _poll_during_flights(
145130
"""
146131
Poll until every injected flights have been observed.
147132
148-
:param diagonals_m: List of diagonals in meters used by the virtual observer to fetch flights.
149133
:param evaluation_func: This method is called on each polling tick with the area to observe. It is responsible
150134
to fetch flights and to return the list of observed injected ids.
151135
"""
@@ -174,7 +158,7 @@ def poll_func(rect: LatLngRect) -> bool:
174158

175159
virtual_observer.start_polling(
176160
config.min_polling_interval.timedelta,
177-
diagonals_m,
161+
[self._rid_version.max_diagonal_km * 1000 - 100],
178162
poll_func,
179163
)
180164

0 commit comments

Comments
 (0)