consider not setting EPP to balance_power when on battery

6473934#diff-fb997c21d1ef39b08732f059fb512ee26cd72af55a8339061e8054a27288c856R610 does this.

See https://gitlab.freedesktop.org/upower/power-profiles-daemon/-/issues/151 for why this is a bad idea. Also, wasn't Intel's whole deal the "race to idle" thing?

[zhang-rui]

Hi @stereomato
thanks for raising this, give me some time to grab more details before making any changes.

[spandruvada]

It is not that we want to set different EPP unless user defines a config entry, but we don't want to override what PPD set. I think PPD is still setting balance_power EPP on DC. If LPMD service is stopped then it needs to restore the default EPP, which PPD would have set as it may race with that.

tuned-ppd (which is default on fedora, included on arch repos and soon to be on nixOS which i'm currently running) lets you configure what epp is set when changing power source. I set it to balance-performance because for intel platforms is what supposedly intel said was the most appropriate + balance_power leads to laggy UI across desktops (happens on gnome and kde, more so on kde)

[zhang-rui]

we check battery mode only when ppd is connect, or else, we will just restore the cached EPP value when lpmd was launched.
are you running with ppd or tuned-ppd connected?

Yeah, actually, this was due to a change in power-profiles-daemon that set epp to balance_power, sorry!

hmmm, I have ppd patched to not do that, but i still see lpmd setting stuff to balance_power