the validation of mp4 metadata?

[mattli001]

Use ffmpeg yami transcode, the mp4 metadata seems with some error.
After use ffmpeg copy codec to do remux, it be fine.

Test step as below:

Step1

Convert 1080p to 720p by libyam_h264. It is base on ffmpeg_libyami_V1.0.0

# ffmpeg -y -c:v libyami_h264 -i /data/media-sample/bbb_sunflower_1080p_30fps_normal.mp4 \
-vf "yamivpp=w=1280:h=720" -c:v libyami_h264 -c:a copy -f mp4 /data/bbb_yami_720.mp4

Step2

mp4info - Utility to display MP4 file summary

# sudo apt-get install mp4v2-utils
# mp4info /data/bbb_yami_720.mp4 
mp4info version 2.0.0
bbb_yami_720.mp4:
ReadProperties: atom 'avcC' is too small; overrun at property: configurationVersion (src/mp4atom.cpp,386)
mp4info: can't open bbb_yami_720.mp4

Step3

remux by ffmpeg copy.

# ffmpeg -i /data/bbb_yami_720.mp4 -codec copy -f mp4 /data/bbb_yami_720-remux.mp4

Step4

display mp4 info again.

# mp4info bbb_yami_720-remux.mp4 
mp4info version 2.0.0
bbb_yami_720-remux.mp4:
Track   Type    Info
1       video   H264 Main@4, 634.600 secs, 4946 kbps, 1280x720 @ 30.000000 fps
2       audio   ac-3, 634.144 secs, 320 kbps, 48000 Hz
 Name: Big Buck Bunny, Sunflower version
 Artist: Blender Foundation 2008, Janus Bager Kristensen 2013
 Composer: Sacha Goedegebure
 Encoded with: Lavf57.51.100
 Genre: Animation
 Comments: Creative Commons Attribution 3.0 - http://bbb3d.renderfarming.net

[mypopydev]

@mattli001 We will check this issue, tks

[mypopydev]

@mattli001 the merge #33 have fixed this issue, please double-check. Thanks.

[mattli001]

@mypopydev It still not work when output format mp4.
I have tested with remove the condition check of https://github.com/01org/ffmpeg_libyami/blob/2c037508e6f03c7a73b878a1b6070ee7d0665512/libavcodec/libyami_enc.cpp#L316

if (avctx->flags & AV_CODEC_FLAG_GLOBAL_HEADER) {
}

Then the output mp4 file check by mp4info will workable.

[mypopydev]

@mattli001 Thanks the confirm, will submit the other patch for this.