version is 0.4.0 but files are called dleyna-core-1.0

[cpanceac]

if we look in change log, latest version is 0.4.0 but in dleyna-core-1.0.pc.in there are file generated called dleyna-1.0 or similar. Looks like something is wrong here.

[jku]

0.4.0, or now 0.5.0, is the project (source) release number. The version is set in configure.ac but Changelog hasn't been updated to 0.5.0: this makes some sort of sense since it's not been released. This is a number we must be able to change whenever we want.

I think dleyna-1.0 as include dir and library name is ok if a bit confusing -- think of it as "dleyna V1" vs "some unreleased version of dleyna that could be parallel installed with dleyna V1 and is basically a separate piece of software".

The one version I'm not sure about is in the shared library real name: libdleyna-core-1.0.so.3.0.0. This was last changed for dleyna source release 0.4.0. I'm not even close to a library versioning expert so I'll have to read up before I do anything about that though...

If you have specific concerns, I'd be happy to hear them (as I said, this is not really my expertise).

[jku]

Ah yes, the .so version bump only makes sense at release time: Because there is added API in settings, we'll probably want to go to DLEYNA_CORE_VERSION 4.0.1 (which should still lead to a libdleyna-core-1.0.so.3.0.0 because libtool magic) but I'll need to run that by an expert.

[cpanceac]

ok, so it would be way clearer to use dleyna-core-1.0 only when dleyna-core version is 1.0 :)

[jku]

So just to be sure: the problem is that source release version (0.4.0) doesn't have the same major version number as the library name (dleyna-core-1.0)? That we could fix but of course the numbers still wouldn't match exactly because of bug fixes etc: you'd have e.g. "dleyna-core-1.0" source version "1.1.21".

Did I understand it correctly?

[cpanceac]

Yes, the problem is that the package is dleyna-core-0.4.0 but the files are called dleyna-core-1.0 or dleyna-1.0 .