Skip to content

Quite a few messages with space before newline #142

@ColinIanKing

Description

@ColinIanKing

writing a space before a newline is generally a redundant I/O logging operation and when writing to a tty it can also force an unwanted line wrap line feed when it's the last character on the end of the tty line. I suspect the " \n" can be replaced with "\n"

git grep -F ' \n"'
include/qz_utils.h:    fprintf(fd, " \n"); \
src/qatzip.c:                        QZ_DEBUG("\tHW DecompOut: endOfLastBlock \n");
src/qatzip_stream.c:                QZ_INFO("Recoverable buffer error occurs... \n");
src/qatzip_utils.c:        QZ_DEBUG("checkHeader: DEFLATE_GZIP compressed_sz = %u , uncompressed_sz = %u \n",
src/qatzip_utils.c:        QZ_DEBUG("checkHeader: DEFLATE_GZIP_EXT compressed_sz = %u , uncompressed_sz = %u \n",
src/qatzip_utils.c:        QZ_DEBUG("checkHeader: DEFLATE_RAW HW Decompression enabled uncompressed_sz is %u \n",
src/qatzip_utils.c:        QZ_DEBUG("checkHeader DEFLATE_ZLIB: compressed_sz %u  uncompressed_sz %u \n",
src/qatzip_utils.c:        QZ_DEBUG("\tHW setDeflateEndOfStream: setting end_of_stream to %d \n", val);
src/qatzip_utils.c:        QZ_DEBUG("\tHW getDeflateEndOfStream:  end_of_stream  %d \n",
test/main.c:            QZ_DEBUG("calling  qzSetupDeflateExt \n");
test/main.c:    QZ_DEBUG("qzTestStopDecompressionOnStreamEndZlib decompress  multicomp_sz : %lu \n",
test/main.c:        QZ_ERROR("T#############T ERROR: qzDecompressStream negative test FAILED: %d*** \n",
test/main.c:    QZ_DEBUG("T#############T: qzDecompressStream return value: %d*** \n", rc);
test/main.c:        QZ_ERROR("\nT#############T ERROR: qzEndStream negative test FAILED,return: %d*** \n",
test/main.c:    QZ_DEBUG("T#############T: qzEndStream return value: %d*** \n", rc);
test/main.c:            QZ_ERROR("ERROR: HW/SW mixed function test in: %s \n", test_params[i].name);
test/main.c:    "                          default by random generate data \n"              \
test/main.c:    "                          0 means no forking permitted. \n"                \
test/main.c:    "                          and maximum is 1M. Default is -1, don't split \n" \
test/main.c:    "                          For zlib and deflate raw the block size must be same \n"\
test/main.c:    "                          as HW buffer size, e.g '-b' and '-C' should be same. \n" \
test/main.c:    "                          when set busy polling mode, it would automatically \n"    \
test/main.c:    "                          enable the LSM(latency sensitive mode) \n"    \
utils/qzip_7z.c:        QZ_DEBUG("Develop ID: %lx \n", eheader->propertyInfo->id);
utils/qzip_7z.c:        QZ_DEBUG("    NumUnpackSubstreamsInFolders: \n");
utils/qzip_7z.c:                QZ_DEBUG("\n unpacksize: \n");
utils/qzip_7z.c:            QZ_DEBUG("codec id: %0x %0x %0x \n",
utils/qzip_7z.c:                QZ_DEBUG("every folder has one file. No unpacksize part. \n");
utils/qzip_7z.c:            QZ_DEBUG("resolve kSize(0x09) done \n");
utils/qzip_7z.c:                        QZ_ERROR("errors ocurs: %s \n", strerror(errno));
utils/qzip_main.c:                                 "going to decompress ... \n");

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions