Unnecessary Operation?

[RylanSchaeffer]

This line is tripping me up:

https://github.com/csmfindling/behavior_models/blob/master/models/expSmoothing_prevAction.py#L48

As far as I can tell, it does nothing. I added an assert statement to check its size is zero and no error was thrown.

[RylanSchaeffer]

Ok, I think I figured out what's going on: you're trying to handle trials in which no action was taken, so you filter these using act[:,t-1]!=0. The aforementioned line is then to propagate values forward one time step in the trials where no action was taken.

[RylanSchaeffer]

If this is correct, I would strongly recommend adding an explanatory comment or changing the implementation to be more clear. Adding an if statement might be a tad slower, but it would be a hell of a lot more clear.