Skip to content

Set frame to NOOP if compressor can't match the error provided. #127

@cjrolo

Description

@cjrolo

Describe the Bug

If a compressor is selected with a given error level (e.g. 1%) and the compressor can't do that error level or less, the compressor should default to NOOP (No compressor) instead of returning a compressed set but above the error requested.

Currently it works as a "best effort" to get the error provided but I think it should be mandatory to be below the error provided in the input.

To Reproduce

Steps to reproduce the behavior:

  1. Compress a file that is not very compressible with a low error like 1%
  2. Check the output error level
  3. Error will be higher than 1%

Expected Behavior

If a file can't be compressed with an error below the one provided, WARN and use a NOOP frame.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions