-
Notifications
You must be signed in to change notification settings - Fork 31
Open
Description
Expected Behavior
As we are now handling journal letters like the rest of the world, we don't need to mangle journal names anymore to conform to Legacy's wrong concept of journal title and volume.
Current Behavior
The get_journal_and_section util is used to split the letter of the volume:
Lines 302 to 321 in 3b8b456
| def get_journal_and_section(publication): | |
| """Take journal title string and try to extract possible section letter.""" | |
| section = '' | |
| journal_title = '' | |
| possible_sections = ["A", "B", "C", "D", "E"] | |
| try: | |
| split_pub = filter(None, re.split(r'(\W+)', publication)) | |
| if split_pub[-1] in possible_sections: | |
| section = split_pub.pop(-1) | |
| journal_title = "".join( | |
| [ | |
| word | |
| for word in split_pub | |
| if "section" not in word.lower() | |
| ] | |
| ).strip(", ") | |
| except IndexError: | |
| pass | |
| return journal_title, section |
Metadata
Metadata
Assignees
Labels
No labels