Fix: Show backtrace for ArrowError (apache#17204)

* fix backtrace for ArrowError

* Update datafusion-cli/tests/cli_integration.rs

* fix tests

Author: 2010YOUY01

.github/workflows/rust.yml

@@ -322,7 +322,7 @@ jobs:
           AWS_SECRET_ACCESS_KEY: TEST-DataFusionPassword
           TEST_STORAGE_INTEGRATION: 1
           AWS_ALLOW_HTTP: true
-        run: cargo test --profile ci -p datafusion-cli  --lib --tests --bins
+        run: cargo test --features backtrace --profile ci -p datafusion-cli  --lib --tests --bins
       - name: Verify Working Directory Clean
         run: git diff --exit-code
 

datafusion-cli/tests/cli_integration.rs

@@ -332,3 +332,30 @@ SELECT COUNT(*) FROM hits;
         .env_remove("AWS_ENDPOINT")
         .pass_stdin(input));
 }
+
+/// Ensure backtrace will be printed, if executing `datafusion-cli` with a query
+/// that triggers error.
+/// Example:
+///     RUST_BACKTRACE=1 cargo run --features backtrace -- -c 'select pow(1,'foo');'
+#[rstest]
+#[case("SELECT pow(1,'foo')")]
+#[case("SELECT CAST('not_a_number' AS INTEGER);")]
+fn test_backtrace_output(#[case] query: &str) {
+    let mut cmd = cli();
+    // Use a command that will cause an error and trigger backtrace
+    cmd.args(["--command", query, "-q"])
+        .env("RUST_BACKTRACE", "1"); // Enable backtrace
+
+    let output = cmd.output().expect("Failed to execute command");
+    let stdout = String::from_utf8_lossy(&output.stdout);
+    let stderr = String::from_utf8_lossy(&output.stderr);
+    let combined_output = format!("{}{}", stdout, stderr);
+
+    // Assert that the output includes literal 'backtrace'
+    assert!(
+        combined_output.to_lowercase().contains("backtrace"),
+        "Expected output to contain 'backtrace', but got stdout: '{}' stderr: '{}'",
+        stdout,
+        stderr
+    );
+}

datafusion/common/src/error.rs

@@ -276,7 +276,7 @@ impl From<io::Error> for DataFusionError {
 
 impl From<ArrowError> for DataFusionError {
     fn from(e: ArrowError) -> Self {
-        DataFusionError::ArrowError(Box::new(e), None)
+        DataFusionError::ArrowError(Box::new(e), Some(DataFusionError::get_back_trace()))
     }
 }
 

datafusion/core/src/datasource/file_format/arrow.rs

@@ -515,7 +515,7 @@ mod tests {
         assert!(err.is_err());
         assert_eq!(
             "Arrow error: Parser error: Unexpected end of byte stream for Arrow IPC file",
-            err.unwrap_err().to_string()
+            err.unwrap_err().to_string().lines().next().unwrap()
         );
 
         Ok(())

datafusion/spark/src/function/bitwise/bit_get.rs

@@ -234,14 +234,20 @@ mod tests {
             Arc::new(Int64Array::from(vec![11])),
             Arc::new(Int32Array::from(vec![-1])),
         ]);
-        assert_eq!(result.unwrap_err().message(), "Compute error: bit_get: position -1 is out of bounds. Expected pos < 64 and pos >= 0");
+        assert_eq!(
+            result.unwrap_err().message().lines().next().unwrap(),
+            "Compute error: bit_get: position -1 is out of bounds. Expected pos < 64 and pos >= 0"
+        );
 
         let result = spark_bit_get(&[
             Arc::new(Int64Array::from(vec![11])),
             Arc::new(Int32Array::from(vec![64])),
         ]);
 
-        assert_eq!(result.unwrap_err().message(), "Compute error: bit_get: position 64 is out of bounds. Expected pos < 64 and pos >= 0");
+        assert_eq!(
+            result.unwrap_err().message().lines().next().unwrap(),
+            "Compute error: bit_get: position 64 is out of bounds. Expected pos < 64 and pos >= 0"
+        );
     }
 
     #[test]