-
Notifications
You must be signed in to change notification settings - Fork 19
Open
Description
Specifically, this code here:
boxtree/boxtree/pyfmmlib_integration.py
Lines 379 to 394 in d48fcdf
| # FIXME: dipole_vec shouldn't be stored here! Otherwise, we'll recompute | |
| # bunches of tree-dependent stuff for every new dipole vector. | |
| # It's not super bad because the dipole vectors are typically geometry | |
| # normals and thus change about at the same time as the tree... but there's | |
| # still no reason for them to be here. | |
| self.use_dipoles = dipole_vec is not None | |
| if self.use_dipoles: | |
| assert dipole_vec.shape == (self.dim, self.tree.nsources) | |
| if not dipoles_already_reordered: | |
| dipole_vec = self.reorder_sources(dipole_vec) | |
| self.dipole_vec = dipole_vec.copy(order="F") | |
| else: | |
| self.dipole_vec = None |
should not exist.
cc @gaohao95
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels