From 8cdd0d2e8adef8cb57d6d5ac2622ac4e675c0d32 Mon Sep 17 00:00:00 2001 From: Nelson Vides Date: Sun, 8 Feb 2026 12:42:59 +0100 Subject: [PATCH 1/3] Make cancel_timer async as its result is not needed --- src/wpool_utils.erl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wpool_utils.erl b/src/wpool_utils.erl index 743884e..58ebe11 100644 --- a/src/wpool_utils.erl +++ b/src/wpool_utils.erl @@ -44,7 +44,7 @@ task_init(Task, task_end(undefined) -> erlang:erase(wpool_task); task_end(TimerRef) -> - _ = erlang:cancel_timer(TimerRef), + _ = erlang:cancel_timer(TimerRef, [{async, true}, {info, false}]), erlang:erase(wpool_task). %% @doc Adds default parameters to a pool configuration From cb2bba804713fef9b3eda76b66c4f6bd6bb84efe Mon Sep 17 00:00:00 2001 From: Nelson Vides Date: Sun, 8 Feb 2026 12:45:47 +0100 Subject: [PATCH 2/3] Upgrade CI --- .github/workflows/erlang.yml | 22 ++++++++++++---------- .tool-versions | 2 -- 2 files changed, 12 insertions(+), 12 deletions(-) delete mode 100644 .tool-versions diff --git a/.github/workflows/erlang.yml b/.github/workflows/erlang.yml index 991f332..bdee1f3 100644 --- a/.github/workflows/erlang.yml +++ b/.github/workflows/erlang.yml @@ -10,25 +10,27 @@ on: workflow_dispatch: {} jobs: - build: - runs-on: ubuntu-24.04 - + name: OTP:${{matrix.otp}} + strategy: + matrix: + otp: ['28', '27'] + rebar3: ['3.26'] steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v6 - uses: erlef/setup-beam@v1 id: setup-beam with: - version-type: strict - version-file: .tool-versions + otp-version: ${{matrix.otp}} + rebar3-version: ${{matrix.rebar3}} - name: Restore _build - uses: actions/cache@v4 + uses: actions/cache@v5 with: path: _build key: _build-cache-for-os-${{runner.os}}-otp-${{steps.setup-beam.outputs.otp-version}}-rebar3-${{steps.setup-beam.outputs.rebar3-version}}-hash-${{hashFiles('rebar.lock')}} - name: Restore rebar3's cache - uses: actions/cache@v4 + uses: actions/cache@v5 with: path: ~/.cache/rebar3 key: rebar3-cache-for-os-${{runner.os}}-otp-${{steps.setup-beam.outputs.otp-version}}-rebar3-${{steps.setup-beam.outputs.rebar3-version}}-hash-${{hashFiles('rebar.lock')}} @@ -39,9 +41,9 @@ jobs: - name: Run tests and verifications run: rebar3 test - name: Upload code coverage - uses: codecov/codecov-action@v4 + uses: codecov/codecov-action@v5 with: - file: "_build/test/covertool/worker_pool.covertool.xml" + files: ./_build/test/covertool/worker_pool.covertool.xml token: ${{ secrets.CODECOV_TOKEN }} fail_ci_if_error: true verbose: true diff --git a/.tool-versions b/.tool-versions deleted file mode 100644 index d890b70..0000000 --- a/.tool-versions +++ /dev/null @@ -1,2 +0,0 @@ -erlang 27.0.1 -rebar 3.25.0 From 29d0a5a0255643d356f405436499466becd49d1f Mon Sep 17 00:00:00 2001 From: Nelson Vides Date: Sun, 8 Feb 2026 13:05:06 +0100 Subject: [PATCH 3/3] Use faster system_time(second) too --- src/wpool_pool.erl | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/wpool_pool.erl b/src/wpool_pool.erl index 4c9ca8e..1f846e1 100644 --- a/src/wpool_pool.erl +++ b/src/wpool_pool.erl @@ -297,9 +297,7 @@ function_location(Function, Location) -> task(undefined) -> []; task({_TaskId, Started, Task}) -> - Time = - calendar:datetime_to_gregorian_seconds( - calendar:universal_time()), + Time = erlang:system_time(second), [{task, Task}, {runtime, Time - Started}]. %% @doc Set next within the worker pool record. Useful when using