EJSON parameter support

[radiegtya]

Using Meteor.call and Meteor.subscribe parameter is very important for production apps.
For now the parameter still only able to pass strings of object. We can't pass value like integer, Date etc. Maybe we need to make EJSON support.

If I am not wrong we can use this npm package https://www.npmjs.com/package/ejson.

For example:

var filters = {
   createdAt: {$gt: new Date()},
   vote: 5
};
filters = EJSON.stringify(filters); //stringify the object first
filters = EJSON.parse(filters); //make to EJSON obj
Meteor.subscribe('some_collections', [filters], function(someCollections){
   console.log(someCollections);
});

I think the above code should be simplified in "react-native-meteor" module instead manually doing that.
Regards

[Mokto]

Looking up soon ;)

[radiegtya]

This is still happened on v1.0.0-beta2.

when I am doing this subscriptions:

  Meteor.subscribe('messages', {channelId: "general", createdAt: {$lt: new Date()}}, {limit: 1});

then I am doing console.log on server

console.log(typeof(selectors.createdAt.$lt))

the date selectors still have a String value, which it should be Object/Date, and this can be achieved with EJSON. Any plan on upgrading this?

NOTE:

• This is happened on Meteor.subscribe and Meteor.call
• Meteor.collection.find/findOne etc is working just fine

[Mokto]

Hi,

I'm not really familiar with EJSON. But I can EJSON.stringify every parameter sended in subscribe.
The issue is that the meteor server must EJSON.parse the parameters, right ? This plugin has no control on the meteor server. How can I do ?

Pull requests or advices are welcome ;)

[radiegtya]

yeah for now I am still able to do this manually like this

in react native apps:

  startMeteorSubscriptions() {
    var filters = {
       createdAt: {$lt: new Date()},
    };
    filters = EJSON.stringify(filters); //stringify the object first
    Meteor.subscribe('todos', filters);
  }

in Meteor server side:

Meteor.publish('todos', function(selector){
    var selector = EJSON.parse(selector);
    return Todos.find(selector);
});

Btw have you take a look at this plugin? I can use their Meteor call and Meteor subscribe without passing EJSON, and it works just fine. https://www.npmjs.com/package/ddp-client.

I think we should take a look at their source code about how to do that

[Mokto]

https://github.com/hharnisc/node-ddp-client/blob/master/index.js#L112

They stringify the data before sending it. But I do not want to force people to EJSON.parse in server methods.

What do you think ?

[radiegtya]

No they also don't make people need to EJSON.parse in their server methods. They are not only stringify it on client, but also able to make server automatically parse it, still dunno where is the code take place

[radiegtya]

maybe this line

self.socket.send( //<<------ this code, will handle the obj parse
  EJSON.stringify(data) //<<----- this will be build into real object by above code
);

[Mokto]

I do not think so, because they use Websocket like in ddp.js.

I'm lost ^^

[radiegtya]

Is this will not be reworked? Any Info?

[Mokto]

I would like to, but I do not know how to do it yet.

[Mokto]

I just saw this PR from ddp.js plugin.

mondora/ddp.js#19

Maybe this can help, will look if this works soon.

[radiegtya]

nice tell me when it has available

[Mokto]

Done ! ;) Release 1.0.0-beta6