From 960bfda345e8a9f57dea6fe463cface1a68c9dbc Mon Sep 17 00:00:00 2001 From: Ipek Turgul Date: Tue, 11 Mar 2025 12:05:15 +1100 Subject: [PATCH 1/3] SMR-3390: Change transaction failed log level - A lot of transaction fail due to nonce issue and it is producing lots of logs. Change it to debug level --- CHANGELOG.md | 4 ++++ miner/worker.go | 2 +- params/version.go | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index fa2f1c5a0..9793c90e0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). +## [v1.0.0-beta.16] + +- Change noisy log to debug level + ## [v1.0.0-beta.15] - Reduce noisy logs diff --git a/miner/worker.go b/miner/worker.go index 78cb6136a..70eadee91 100644 --- a/miner/worker.go +++ b/miner/worker.go @@ -812,7 +812,7 @@ func (w *worker) commitTransaction(env *environment, tx *types.Transaction) ([]* receipt, err := w.applyTransaction(env, tx) if err != nil { // CHANGE(immutable) add error logging - log.Warn("Transaction failed, discarding", "hash", tx.Hash(), "err", err) + log.Debug("Transaction failed, discarding", "hash", tx.Hash(), "err", err) return nil, err } env.txs = append(env.txs, tx) diff --git a/params/version.go b/params/version.go index f186881a3..8de4f7e73 100644 --- a/params/version.go +++ b/params/version.go @@ -24,7 +24,7 @@ const ( VersionMajor = 1 // Major version component of the current release VersionMinor = 0 // Minor version component of the current release VersionPatch = 0 // Patch version component of the current release - VersionMeta = "beta.15" // Version metadata to append to the version string + VersionMeta = "beta.16" // Version metadata to append to the version string ) // Version holds the textual version string. From 45bea8f19eeaacee6fc2290f5c428fc163e083e9 Mon Sep 17 00:00:00 2001 From: sergerad Date: Tue, 11 Mar 2025 14:31:48 +1300 Subject: [PATCH 2/3] Undo v 16 --- CHANGELOG.md | 4 ---- params/version.go | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9793c90e0..fa2f1c5a0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,10 +6,6 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). -## [v1.0.0-beta.16] - -- Change noisy log to debug level - ## [v1.0.0-beta.15] - Reduce noisy logs diff --git a/params/version.go b/params/version.go index 8de4f7e73..f186881a3 100644 --- a/params/version.go +++ b/params/version.go @@ -24,7 +24,7 @@ const ( VersionMajor = 1 // Major version component of the current release VersionMinor = 0 // Minor version component of the current release VersionPatch = 0 // Patch version component of the current release - VersionMeta = "beta.16" // Version metadata to append to the version string + VersionMeta = "beta.15" // Version metadata to append to the version string ) // Version holds the textual version string. From 3ccf955f6e463dc3caa4dc08b2087af53db148a7 Mon Sep 17 00:00:00 2001 From: sergerad Date: Tue, 11 Mar 2025 14:36:56 +1300 Subject: [PATCH 3/3] Miner commit interval debug --- miner/worker.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/miner/worker.go b/miner/worker.go index 70eadee91..91e507ead 100644 --- a/miner/worker.go +++ b/miner/worker.go @@ -519,11 +519,11 @@ func (w *worker) newWorkLoop(recommit time.Duration) { before := recommit target := float64(recommit.Nanoseconds()) / adjust.ratio recommit = recalcRecommit(minRecommit, recommit, target, true) - log.Warn("Increase miner recommit interval", "from", before, "to", recommit) + log.Debug("Increase miner recommit interval", "from", before, "to", recommit) } else { before := recommit recommit = recalcRecommit(minRecommit, recommit, float64(minRecommit.Nanoseconds()), false) - log.Warn("Decrease miner recommit interval", "from", before, "to", recommit) + log.Debug("Decrease miner recommit interval", "from", before, "to", recommit) } if w.resubmitHook != nil {