issue with the modal Vue component #49
Description
Having issues with this…might create a PR sometime but Tristan would likely need to do last bullet.
- documentation: no mention that an empty
#mountedelement needs to exist in markup - can we overwrite this name similarly to how we can overwrite other classes via a prop? - documentation: can we talk about how this relies on portal-vue as a dependency? this is not an issue if you use Boilerplate, but I brought this to an existing project Imarc project and wasn't sure what was wrong initially
- the notes say that this package sends the content to the end of
<body>but I am not seeing that
- the notes say that this package sends the content to the end of
- documentation: we have an accordion mention in there
- we give no
z-indexto this and it appears under other elements on a page that create a new stacking context - it's good we put focus into the modal when it's open but we should probably be limiting the focus to the modal. right now, a user can continue tabbing through the rest of the document
- we might consider implementing the close button in a way that does not use
font-size: 0. this way, if someone actually wanted text for their close button, they could - we might consider renaming props to be more intuitive.
closeButtonElementto me implies that I could specify what DOM element to use (e.g. a<div>instead of a<button>) but it's just to control the naming. They all use thisElementconvention but theblockprop does not - modal was stripping my HTML. Tristan's fix is: Modal should be able to discern between encoded content or straight html, whether by sniffing it out automatically, or via boolean prop.